Fix nil point dereference in notifyEvent #1050
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chun Chen <ramichen@tencent.com>
|
@chenchun I did some more investigation and a defensive check in this case will hide the issue rather than solving the root-cause. The correct fix is to make sure the leave processing happen even if the delete endpoint takes place before the Serf gets a chance to distribute the event to the neighbors. I am working on the proper fix for this. We can close this PR if we are all happy with my upcoming patch. |
|
@mavenugo Thanks. Your fix makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Chun Chen ramichen@tencent.com
Don't know how the scenarios mentioned in #985 happened.
But I think we should prevent daemon crash.