Remove caching UDP connections to external nameservers #1068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Santhosh Manohar <santhosh@docker.com>
|
LGTM |
|
Having the cache makes the forwarded query handling more optimal. Will push a new PR to address the concurrent query issue while retaining the caching logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An optimization was added earlier to cache the connections to external UDP servers so that it can be reused for subsequent queries. But this creates an issue when multiple concurrent queries are sent on the connection and replies come back in a different order. This PR removes the udp connection caching in embedded DNS server.
Fixes #1070
Signed-off-by: Santhosh Manohar santhosh@docker.com