Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump hashicorp/memberlist v0.1.4, hashicorp/serf v0.8.3 #2441

Closed
wants to merge 6 commits into from

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 26, 2019

built on top of #2440, but keeping this separate as it's a bigger change in dependency, and adds some new ones.

bump hashicorp/memberlist v0.1.4

full diff: hashicorp/memberlist@3d8438d...v0.1.4

bump hashicorp/go-msgpack v0.5.5

full diff: hashicorp/go-msgpack@71c2886...v0.5.5

bump hashicorp/serf v0.8.3

full diff hashicorp/serf@598c548...v0.8.3

Changelog: https://github.com/hashicorp/serf/blob/v0.8.3/CHANGELOG.md

We were previously 47 commits ahead of v0.7.0 (v0.7.0-47-g598c548), 60 commits behind v0.8.0

bump armon/go-metrics ec5e00d3c878b2a97bbe0884ef45ffd1b4f669f5

full diff: hashicorp/go-metrics@eb0af21...ec5e00d

@thaJeztah thaJeztah force-pushed the bump_memberlist branch 3 times, most recently from 325ae56 to 7e9369b Compare August 26, 2019 16:52
@thaJeztah thaJeztah force-pushed the bump_memberlist branch 2 times, most recently from b86c623 to 4d669b5 Compare February 26, 2020 21:10
@thaJeztah
Copy link
Member Author

thaJeztah commented Feb 26, 2020

one failure;

=== RUN   TestNetworkDBCRUDTableEntries
2020/02/26 21:17:43 Closing DB instances...
--- FAIL: TestNetworkDBCRUDTableEntries (7.61s)
    networkdb_test.go:141: Entry existence verification test failed for node2(9dab403365ae)

failure above is difficult to locate, because the error occurs in a helper that's used in many tests. Pushing a commit to mark helper-functions as t.Helper() to see if the output is more usable

@thaJeztah
Copy link
Member Author

.....and now it passes of course, LOL. Looks like it's just a flaky test

full diff: hashicorp/memberlist@3d8438d...v0.1.4

- hashicorp/memberlist#158 Limit concurrent push/pull connections
- hashicorp/memberlist#159 Prioritize alive message over other messages
- hashicorp/memberlist#168 Add go.mod
- hashicorp/memberlist#167 Various changes to improve the cpu impact of TransmitLimitedQueue in large clusters
- hashicorp/memberlist#169 added back-off to accept loop to avoid a tight loop
- hashicorp/memberlist#178 Avoid to take into account wrong versions of protocols in Vsn
- hashicorp/memberlist#189 Allow a dead node's name to be taken by a new node

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: hashicorp/go-msgpack@71c2886...v0.5.5

- hashicorp/go-msgpack#3 Add go.mod
- hashicorp/go-msgpack#7 Do not attempt to set unsettable types
- hashicorp/go-msgpack#8 codec: do not dereference pointers/interfaces for omitempty support
  - backport of hashicorp/go-msgpack@006e153
  - backport of hashicorp/go-msgpack@006e153
  - fixes ugorji/go#67 "omitempty" fails on pointers to bools

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Changelog: https://github.com/hashicorp/serf/blob/v0.8.3/CHANGELOG.md

full diff hashicorp/serf@598c548...v0.8.3

We were previously 47 commits ahead of v0.7.0 (v0.7.0-47-g598c548), 60 commits behind v0.8.0

- hashicorp/serf@v0.7.0...598c548
- hashicorp/serf@598c548...v0.8.0

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

Rebased this PR, and had the same failure as above, so could be related

=== RUN   TestNetworkDBCRUDTableEntries
2021/05/11 12:46:55 Closing DB instances...
--- FAIL: TestNetworkDBCRUDTableEntries (7.61s)
    networkdb_test.go:141: Entry existence verification test failed for node2(4930d64b17a6)

@thaJeztah
Copy link
Member Author

nope; passes again now, so looks to be just flaky

@thaJeztah
Copy link
Member Author

@cpuguy83 @AkihiroSuda @arkodg ptal

@cpuguy83
Copy link
Member

Can we hold off until libnetwork is merged into moby?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"omitempty" fails on pointers to bools
3 participants