Cleanup VFP during overlay network removal #2524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deleting a network sandbox on Linux implicitly clears OS (ipvs) load balancer state. Deleting an HNS network on Windows by contrast does not inherently remove its corresponding VFP load balancers. The method to remove load balancers belongs to the network and so must be called prior to or while deleting a network. This commit reverts one line from c47239d, reintroducing a call to explicitly remove backend load balancers during network removal. Signed-off-by: Trapier Marshall <tmarshall@mirantis.com>
This was referenced Mar 4, 2020
|
introduced in #2138 (adding a link for easier discovery) |
|
@msabansal ptal |
euanh
approved these changes
Mar 5, 2020
|
/cc @pradipd, who I believe initially diagnosed this in the affected customer environment on the basis of missing EDIT: many thanks for the lead Pradip! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleting a network sandbox on Linux implicitly clears OS (ipvs) load
balancer state. Deleting an HNS network on Windows by contrast does not
inherently remove its corresponding VFP load balancers. The method to
remove load balancers belongs to the network and so must be called prior
to or while deleting a network. This commit reverts one line from
c47239d, reintroducing a call to
explicitly remove backend load balancers during network removal.
Fixes #2527
Mirantis Ref: FIELD-2259