Enable sig-proxy by default in run and attach

[vieux]

ping @shykes @crosbymichael @creack

[tianon]

Can we rebase this now that master includes links? :)

[tianon]

Rebased with permission from @shykes; testing now.

[tianon]

Shouldn't this proxy with something simple like docker run -i -t tianon/debian bash ? Here's my output:

tianon@host$ docker run -i -t tianon/debian bash
root@cebc0312a73c:/# trap 'echo hello world!' SIGUSR1
root@cebc0312a73c:/# kill -USR1 $$
hello world!
root@cebc0312a73c:/#

Open second terminal, find PID of docker run (in my case, 4093), and do:

tianon@host$ kill -USR1 4093

No extra output on the first terminal. Shouldn't SIGUSR1 be "proxified" to bash?

[tianon]

Is this saying that if there is a TTY, we always force-disable sig-proxy ?

+  if config.Tty {
+    sigProxy = false
+  }

[vieux]

@tianon yes, because in tty mode, signals are always proxified, using the raw terminal method

[tianon]

So why didn't my SIGUSR1 get proxified?

[crosbymichael]

@vieux

There is something wrong with this branch. I am getting error messages in the tests.

-- PASS: TestImagesFilter (0.14 seconds)
=== RUN TestServerListOrderedImagesByCreationDate
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: 6f785d278165
[error] api.go:78 HTTP Error: statusCode=404 No such container: 6f785d278165
[error] api.go:1023 Error: No such container: f93fbb878f6b
[error] api.go:78 HTTP Error: statusCode=404 No such container: f93fbb878f6b
[error] api.go:1023 Error: No such container: ec391abab5ea
[error] api.go:78 HTTP Error: statusCode=404 No such container: ec391abab5ea
[error] api.go:1023 Error: No such container: 63aa5fc69086
[error] api.go:78 HTTP Error: statusCode=404 No such container: 63aa5fc69086
[error] api.go:1023 Error: No such container: ff5e69349b4d
[error] api.go:78 HTTP Error: statusCode=404 No such container: ff5e69349b4d
[error] api.go:1023 Error: No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e2406ab20316c77eeb07c2afbf04b1d083a4655494ceb22a9cba6700
[error] api.go:1023 Error: No such container: 588ec30a53cf
[error] api.go:78 HTTP Error: statusCode=404 No such container: 588ec30a53cf
[error] api.go:1023 Error: No such container: d290fb38e240
[error] api.go:78 HTTP Error: statusCode=404 No such container: d290fb38e240

[vieux]

@crosbymichael can you take another look ?

[tianon]

Thanks to @vieux, I can verify that this is indeed working for me. :)

[crosbymichael]

Is there a reason why this needs to be in _darwin and _linux, The code is the same.

[crosbymichael]

LGTM