1.12.3 Changelog #27611
1.12.3 Changelog #27611
Conversation
| - Prevent a deadlock in libcontainerd for Windows [#27136](https://github.com/docker/docker/pull/27136) | ||
| - Fix error reporting in CopyFileWithTar [#27075](https://github.com/docker/docker/pull/27075) | ||
| * Reset health status to starting when a container is restarted [#27387](https://github.com/docker/docker/pull/27387) | ||
| * Remount everything as private in new mntns [#27609](https://github.com/docker/docker/pull/27609) |
There was a problem hiding this comment.
Should probably describe what it's fixing as well; Also should this be in the "Builder" section?
* Fix an error when trying to `ADD` or `COPY` files to the root (`/`) of the container's filesystem
@tonistiigi SGTY? ^^
There was a problem hiding this comment.
The problem is in file extraction so not directly related to builder. Could probably happen in pull/load/cp as well in certain conditions. I'd add "during extraction ...". Or "Properly handle shared mount propagation in storage directory".
There was a problem hiding this comment.
I like Properly handle shared mount propagation in storage directory
|
|
||
| - Fix conversion of restart-policy [#27062](https://github.com/docker/docker/pull/27062) | ||
| * Vendor Swarmkit [#27554](https://github.com/docker/docker/pull/27554) | ||
| * Avoid restarting a task that has already been restarted [docker/swarmkit#1305] |
There was a problem hiding this comment.
Missing https://github.com/ here and couple below
vieux
force-pushed
the
changelog-1.12.3
branch
3 times, most recently
from
9a35aa3 to
a4f62a0
Compare
|
please take a look @aaronlehmann @mrjana @riyazdf |
| - Fix race in serializing sandbox to string [docker/libnetwork#1495](https://github.com/docker/libnetwork/pull/1495) | ||
| - Fix race during deletion [docker/libnetwork#1503](https://github.com/docker/libnetwork/pull/1503) | ||
| * Reset endpoint port info on connectivity revoke in bridge driver [docker/libnetwork#1504](https://github.com/docker/libnetwork/pull/1504) | ||
|
|
There was a problem hiding this comment.
Add the following as well:
- Fix a deadlock in networking code docker/libnetwork#1507
- Fix a race in load balancer state docker/libnetwork#1512
| ### Swarm Mode | ||
|
|
||
| - Fix conversion of restart-policy [#27062](https://github.com/docker/docker/pull/27062) | ||
| * Vendor Swarmkit [#27554](https://github.com/docker/docker/pull/27554) |
There was a problem hiding this comment.
Maybe "Update" instead of "Vendor"?
There was a problem hiding this comment.
@icecrime we used vendor previously in 1.12.2 already but I can change
|
|
||
| - Fix conversion of restart-policy [#27062](https://github.com/docker/docker/pull/27062) | ||
| * Vendor Swarmkit [#27554](https://github.com/docker/docker/pull/27554) | ||
| * Avoid restarting a task that has already been restarted [https://github.com/docker/swarmkit/pull/1305] |
There was a problem hiding this comment.
I don't know if that's intentional, but this isn't a properly formatted markdown link.
|
|
||
| ### Runtime | ||
|
|
||
| - Fix user permissions in containers (CVE-2016-8867) [#27610](https://github.com/docker/docker/pull/27610) |
There was a problem hiding this comment.
s/Fix user permissions in containers/Fix ambient capability usage in containers/
There was a problem hiding this comment.
CVE-2016-8867 not published yet?
There was a problem hiding this comment.
Not published yet, but we've received a confirmed ID from MITRE.
We will keep everyone posted as we get details back from MITRE, but that pull request and the linked issue describe the ambient capability misconfiguration.
vieux
force-pushed
the
changelog-1.12.3
branch
2 times, most recently
from
4308575 to
a31a9bb
Compare
Signed-off-by: Victor Vieux <vieux@docker.com>
|
LGTM |
| * Reset endpoint port info on connectivity revoke in bridge driver [docker/libnetwork#1504](https://github.com/docker/libnetwork/pull/1504) | ||
| - Fix a deadlock in networking code [docker/libnetwork#1507](https://github.com/docker/libnetwork/pull/1507) | ||
| - Fix a race in load balancer state [docker/libnetwork#1512](https://github.com/docker/libnetwork/pull/1512) | ||
| ### Logging |
There was a problem hiding this comment.
Minor nit: missing new line.
vieux
force-pushed
the
changelog-1.12.3
branch
from
a31a9bb to
548f8f0
Compare
ping @thaJeztah