Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

overlay2: remove unused cdMountFrom() helper function #37041

Merged
merged 1 commit into from
May 11, 2018
Merged

overlay2: remove unused cdMountFrom() helper function #37041

merged 1 commit into from
May 11, 2018

Conversation

thaJeztah
Copy link
Member

This function was added in 23e5c94 (#22126) but never used

@thaJeztah
overlay2: remove unused cdMountFrom() helper function
8a8ec00 
This function was added in 23e5c94 but never used

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from dmcgowan as a code owner May 11, 2018 11:53
AkihiroSuda
AkihiroSuda approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@AkihiroSuda AkihiroSuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we configure lint to detect unused and unexported functions?

cpuguy83
cpuguy83 approved these changes May 11, 2018
View reviewed changes
Copy link
Member

@cpuguy83 cpuguy83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cpuguy83 cpuguy83 merged commit d0a516e into moby:master May 11, 2018
@thaJeztah thaJeztah deleted the remove_unused_function_in_test branch May 11, 2018 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AkihiroSuda AkihiroSuda AkihiroSuda approved these changes

@cpuguy83 cpuguy83 cpuguy83 approved these changes

@dmcgowan dmcgowan Awaiting requested review from dmcgowan

Assignees
No one assigned
Labels
area/storage/overlay area/testing status/2-code-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thaJeztah @cpuguy83 @AkihiroSuda @GordonTheTurtle