Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate "devicemapper" storage driver, and add warning #38017

Merged

Conversation

thaJeztah
Copy link
Member

Related deprecation note PR: docker/cli#1424

The devicemapper storage driver is deprecated in favor of overlay2, and will
be removed in a future release. Users of the devicemapper storage driver are
recommended to migrate to a different storage driver, such as overlay2, which
is now the default storage driver.

The devicemapper storage driver facilitates running Docker on older (3.x) kernels
that have no support for other storage drivers (such as overlay2, or AUFS).

Now that support for overlay2 is added to all supported distros (as they are
either on kernel 4.x, or have support for multiple lowerdirs backported), there
is no reason to continue maintenance of the devicemapper storage driver.

@thaJeztah
Copy link
Member Author

ping @mavenugo @andrewhsu @AkihiroSuda

@thaJeztah
Copy link
Member Author

/cc @rhvgoyal

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐸

@thaJeztah
Copy link
Member Author

d'oh! I moved the warning in the logs to the wrong location; let me update

The `devicemapper` storage driver is deprecated in favor of `overlay2`, and will
be removed in a future release. Users of the `devicemapper` storage driver are
recommended to migrate to a different storage driver, such as `overlay2`, which
is now the default storage driver.

The `devicemapper` storage driver facilitates running Docker on older (3.x) kernels
that have no support for other storage drivers (such as overlay2, or AUFS).

Now that support for `overlay2` is added to all supported distros (as they are
either on kernel 4.x, or have support for multiple lowerdirs backported), there
is no reason to continue maintenance of the `devicemapper` storage driver.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@codecov
Copy link

codecov bot commented Oct 11, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1f48759). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38017   +/-   ##
=========================================
  Coverage          ?   36.09%           
=========================================
  Files             ?      610           
  Lines             ?    45175           
  Branches          ?        0           
=========================================
  Hits              ?    16308           
  Misses            ?    26626           
  Partials          ?     2241

@thaJeztah thaJeztah force-pushed the add_devicemapper_deprecation_warning branch from 31d9f51 to 06fcabb Compare October 11, 2018 13:46
@thaJeztah
Copy link
Member Author

Fixed; should now also warn when a driver is manually selected

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

s390 failure is unrelated;

15:01:00 FAIL: docker_api_swarm_node_test.go:75: DockerSwarmSuite.TestAPISwarmNodeDrainPause
15:01:00 
15:01:00 [dff43245afe45] waiting for daemon to start
15:01:00 [dff43245afe45] daemon started
15:01:00 
15:01:00 [d3fcbc0359b0a] waiting for daemon to start
15:01:00 [d3fcbc0359b0a] daemon started
15:01:00 
15:01:00 docker_api_swarm_node_test.go:104:
15:01:00     waitAndAssert(c, defaultReconciliationTimeout*2, reducedCheck(sumAsIntegers, d1.CheckActiveContainerCount, d2.CheckActiveContainerCount), checker.Equals, instances)
15:01:00 docker_utils_test.go:435:
15:01:00     c.Assert(v, checker, args...)
15:01:00 ... obtained int = 3
15:01:00 ... expected int = 1
15:01:00 ... output: "f3bf56f27764\n81d3d1c9e4c6\n2bd7ac7e950c\n"
15:01:00 
15:01:00 [dff43245afe45] exiting daemon
15:01:00 [d3fcbc0359b0a] exiting daemon
15:01:36 

This was referenced Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants