-
Notifications
You must be signed in to change notification settings - Fork 18.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate "devicemapper" storage driver, and add warning #38017
Deprecate "devicemapper" storage driver, and add warning #38017
Conversation
/cc @rhvgoyal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
d'oh! I moved the warning in the logs to the wrong location; let me update |
The `devicemapper` storage driver is deprecated in favor of `overlay2`, and will be removed in a future release. Users of the `devicemapper` storage driver are recommended to migrate to a different storage driver, such as `overlay2`, which is now the default storage driver. The `devicemapper` storage driver facilitates running Docker on older (3.x) kernels that have no support for other storage drivers (such as overlay2, or AUFS). Now that support for `overlay2` is added to all supported distros (as they are either on kernel 4.x, or have support for multiple lowerdirs backported), there is no reason to continue maintenance of the `devicemapper` storage driver. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #38017 +/- ##
=========================================
Coverage ? 36.09%
=========================================
Files ? 610
Lines ? 45175
Branches ? 0
=========================================
Hits ? 16308
Misses ? 26626
Partials ? 2241 |
31d9f51
to
06fcabb
Compare
Fixed; should now also warn when a driver is manually selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
s390 failure is unrelated;
|
Related deprecation note PR: docker/cli#1424
The
devicemapper
storage driver is deprecated in favor ofoverlay2
, and willbe removed in a future release. Users of the
devicemapper
storage driver arerecommended to migrate to a different storage driver, such as
overlay2
, whichis now the default storage driver.
The
devicemapper
storage driver facilitates running Docker on older (3.x) kernelsthat have no support for other storage drivers (such as overlay2, or AUFS).
Now that support for
overlay2
is added to all supported distros (as they areeither on kernel 4.x, or have support for multiple lowerdirs backported), there
is no reason to continue maintenance of the
devicemapper
storage driver.