Remove skip evaluation of symlinks to data root on IoT Core #38020

thaJeztah · 2018-10-11T14:37:32Z

This fix was added in 8e71b1e (#33498) to work around a go issue (golang/go#20506).

That issue was fixed in golang/go@66c03d3,
which is part of Go 1.10 and up. This reverts the changes that were made in
8e71b1e, and are no longer needed.

thaJeztah · 2018-10-11T14:38:51Z

pkg/system/syscall_windows.go

@@ -120,8 +120,6 @@ func IsWindowsClient() bool {

 // IsIoTCore returns true if the currently running image is based off of
 // Windows 10 IoT Core.
-// @engine maintainers - this function should not be removed or modified as it
-// is used to enforce licensing restrictions on Windows.
 func IsIoTCore() bool {


Looks like this function is no longer used in our code, so perhaps we can remove it altogether (a quick search on GitHub also didn't show any users of this)

Yes, this is the last user of this function after #38000

thaJeztah · 2018-10-11T14:38:58Z

ping @jhowardmsft @darstahl PTAL 🤗

lowenna · 2018-10-11T16:39:02Z

@taylorb-microsoft Can you loop in one of the IoT guys to verify. I believe this is OK, but I'd like their verification first.

thaJeztah · 2018-10-11T16:59:52Z

Thanks! Yes; this was purely based on that comment, so would be good to double check 🤗

darstahl · 2018-10-11T20:11:25Z

I no longer have an environment to test this, but LGTM pending verification that it works as intended on an IoT build.

codecov · 2018-10-12T00:01:46Z

Codecov Report

❗ No coverage uploaded for pull request base (master@44a3267). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38020   +/-   ##
=========================================
  Coverage          ?   37.32%           
=========================================
  Files             ?      609           
  Lines             ?    45231           
  Branches          ?        0           
=========================================
  Hits              ?    16882           
  Misses            ?    26056           
  Partials          ?     2293

lowenna · 2018-10-12T17:08:08Z

Hold fire on this - internal testing is throwing an issue. It's being investigated.

lowenna · 2018-11-14T19:11:19Z

@jiria Following on from our discussion yesterday, are you OK with this? I think it's safe now, but if you can confirm.

jiria · 2018-11-14T19:48:08Z

@jhowardmsft looks good to me.

thaJeztah · 2018-11-14T19:54:25Z

rebased, and removed "WIP"

thaJeztah · 2019-04-02T11:50:45Z

rebased again; @jhowardmsft @kolyshkin PTAL

This fix was added in 8e71b1e to work around a go issue (golang/go#20506). That issue was fixed in golang/go@66c03d3, which is part of Go 1.10 and up. This reverts the changes that were made in 8e71b1e, and are no longer needed. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2019-07-14T14:28:11Z

Experimental failure looks to be a flaky; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/45949/console

11:18:38 FAIL: docker_api_swarm_node_test.go:75: DockerSwarmSuite.TestAPISwarmNodeDrainPause
11:18:38 
11:18:38 Creating a new daemon
11:18:38 [dc139d4dd25da] waiting for daemon to start
11:18:38 [dc139d4dd25da] waiting for daemon to start
11:18:38 [dc139d4dd25da] daemon started
11:18:38 
11:18:38 Creating a new daemon
11:18:38 [d53117bd699ed] waiting for daemon to start
11:18:38 [d53117bd699ed] waiting for daemon to start
11:18:38 [d53117bd699ed] daemon started
11:18:38 
11:18:38 waited for 707.626002ms (out of 30s)
11:18:38 waited for 9.542429ms (out of 30s)
11:18:38 waited for 18.527488ms (out of 30s)
11:18:38 waited for 2.227709728s (out of 30s)
11:18:38 waited for 8.748001ms (out of 30s)
11:18:38 docker_api_swarm_node_test.go:103:
11:18:38     waitAndAssert(c, defaultReconciliationTimeout*2, reducedCheck(sumAsIntegers, d1.CheckActiveContainerCount, d2.CheckActiveContainerCount), checker.Equals, instances)
11:18:38 docker_utils_test.go:435:
11:18:38     c.Assert(v, checker, args...)
11:18:38 ... obtained int = 2
11:18:38 ... expected int = 1
11:18:38 ... output: "801028f0f936\ne5772591d4b2\n"
11:18:38 
11:18:38 waited for 1m0.063567148s (out of 1m0s)
11:18:38 [dc139d4dd25da] Stopping daemon
11:18:38 [dc139d4dd25da] exiting daemon
11:18:38 [dc139d4dd25da] Daemon stopped
11:18:38 [d53117bd699ed] Stopping daemon
11:18:38 [d53117bd699ed] exiting daemon
11:18:38 [d53117bd699ed] Daemon stopped

Daemon logs attached:

d53117bd699ed.log

time="2019-07-14T11:17:29.017856674Z" level=error msg="error in agentInit: failed to create memberlist: Could not set up network transport: failed to obtain an address: Failed to start TCP listener on \"0.0.0.0\" port 7946: listen tcp 0.0.0.0:7946: bind: address already in use"
time="2019-07-14T11:17:29.017973645Z" level=error msg="error in agentInit: failed to create memberlist: Could not set up network transport: failed to obtain an address: Failed to start TCP listener on \"0.0.0.0\" port 7946: listen tcp 0.0.0.0:7946: bind: address already in use"
time="2019-07-14T11:18:33.144068234Z" level=error msg="agent: session failed" backoff=100ms error=EOF module=node/agent node.id=vtpt9qjni2iiv4gkef4rl7c0f
time="2019-07-14T11:18:33.230004641Z" level=error msg="agent: session failed" backoff=300ms error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:2477: connect: connection refused\"" module=node/agent node.id=vtpt9qjni2iiv4gkef4rl7c0f
time="2019-07-14T11:18:33.429552477Z" level=error msg="agent: session failed" backoff=700ms error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:2477: connect: connection refused\"" module=node/agent node.id=vtpt9qjni2iiv4gkef4rl7c0f
time="2019-07-14T11:18:33.697972438Z" level=error msg="agent: session failed" backoff=1.5s error="rpc error: code = Unavailable desc = all SubConns are in TransientFailure, latest connection error: connection error: desc = \"transport: Error while dialing dial tcp 127.0.0.1:2477: connect: connection refused\"" module=node/agent node.id=vtpt9qjni2iiv4gkef4rl7c0f

dc139d4dd25da.log

time="2019-07-14T11:17:28.210168437Z" level=error msg="error reading the kernel parameter net.ipv4.neigh.default.gc_thresh1" error="open /proc/sys/net/ipv4/neigh/default/gc_thresh1: no such file or directory"
time="2019-07-14T11:17:28.210183375Z" level=error msg="error reading the kernel parameter net.ipv4.neigh.default.gc_thresh2" error="open /proc/sys/net/ipv4/neigh/default/gc_thresh2: no such file or directory"
time="2019-07-14T11:17:28.210195867Z" level=error msg="error reading the kernel parameter net.ipv4.neigh.default.gc_thresh3" error="open /proc/sys/net/ipv4/neigh/default/gc_thresh3: no such file or directory"
time="2019-07-14T11:17:28.297891584Z" level=error msg="error reading the kernel parameter net.ipv4.vs.expire_nodest_conn" error="open /proc/sys/net/ipv4/vs/expire_nodest_conn: no such file or directory"
time="2019-07-14T11:17:33.046943421Z" level=error msg="failed to update task to REMOVE" error="update out of sequence" module=node node.id=owzw1jvmh1ovxpmpdut7nzyh5
time="2019-07-14T11:18:33.143549161Z" level=error msg="failed to remove node" error="rpc error: code = Aborted desc = dispatcher is stopped" method="(*Dispatcher).Session" node.id=owzw1jvmh1ovxpmpdut7nzyh5 node.session=op23nfmjvobnaek7ds3yo5o74
time="2019-07-14T11:18:33.143688555Z" level=error msg="failed to remove node" error="rpc error: code = Aborted desc = dispatcher is stopped" method="(*Dispatcher).Session" node.id=vtpt9qjni2iiv4gkef4rl7c0f node.session=13w16v5a0m1wtoni0jopeebf4
time="2019-07-14T11:18:33.144002407Z" level=error msg="failed to receive changes from store watch API" error="rpc error: code = Unknown desc = context canceled"
time="2019-07-14T11:18:33.945690551Z" level=error msg="failed to get event" error="rpc error: code = Unavailable desc = transport is closing" module=libcontainerd namespace=dc139d4dd25da

thaJeztah · 2019-07-14T17:02:50Z

ok, this is rebased and green

@jhowardmsft @cpuguy83 @AkihiroSuda PTAL

lowenna

LGTM @jiria FYI

cpuguy83

LGTM

GordonTheTurtle added the status/0-triage label Oct 11, 2018

thaJeztah added status/2-code-review and removed status/0-triage labels Oct 11, 2018

thaJeztah commented Oct 11, 2018

View reviewed changes

feJustino approved these changes Oct 11, 2018

View reviewed changes

thaJeztah added the rebuild/powerpc label Oct 11, 2018

GordonTheTurtle removed the rebuild/powerpc label Oct 11, 2018

thaJeztah changed the title ~~Remove skip evaluation of symlinks to data root on IoT Core~~ [WIP] Remove skip evaluation of symlinks to data root on IoT Core Oct 18, 2018

thaJeztah force-pushed the remove_iot_check branch from e54c880 to b4d945c Compare October 18, 2018 13:54

GordonTheTurtle assigned coolljt0725 Oct 26, 2018

thaJeztah force-pushed the remove_iot_check branch from b4d945c to 4023f8b Compare November 14, 2018 19:53

thaJeztah changed the title ~~[WIP] Remove skip evaluation of symlinks to data root on IoT Core~~ Remove skip evaluation of symlinks to data root on IoT Core Nov 14, 2018

thaJeztah added the platform/windows label Nov 14, 2018

derek bot added the rebuild/* label Dec 21, 2018

GordonTheTurtle removed the rebuild/* label Dec 21, 2018

derek bot added the rebuild/powerpc label Dec 22, 2018

GordonTheTurtle removed the rebuild/powerpc label Dec 22, 2018

thaJeztah force-pushed the remove_iot_check branch from 4023f8b to 40bef75 Compare April 2, 2019 11:50

thaJeztah added the rebuild/* label Apr 2, 2019

GordonTheTurtle removed the rebuild/* label Apr 2, 2019

thaJeztah force-pushed the remove_iot_check branch from 40bef75 to 9f1fa39 Compare July 13, 2019 21:40

thaJeztah added 2 commits July 13, 2019 23:44

Remove unused pkg/system.IsIoTCore()

763454e

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah force-pushed the remove_iot_check branch from 9f1fa39 to 763454e Compare July 13, 2019 21:45

thaJeztah added the rebuild/experimental label Jul 14, 2019

GordonTheTurtle removed the rebuild/experimental label Jul 14, 2019

thaJeztah mentioned this pull request Jul 14, 2019

Flaky test: TestAPISwarmNodeDrainPause #23516

Open

thaJeztah added the rebuild/experimental label Jul 14, 2019

GordonTheTurtle removed the rebuild/experimental label Jul 14, 2019

lowenna approved these changes Jul 15, 2019

View reviewed changes

cpuguy83 approved these changes Jul 15, 2019

View reviewed changes

cpuguy83 merged commit ffabf0d into moby:master Jul 15, 2019

thaJeztah deleted the remove_iot_check branch July 15, 2019 18:14

thaJeztah added this to the 20.03.0 milestone Apr 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove skip evaluation of symlinks to data root on IoT Core #38020

Remove skip evaluation of symlinks to data root on IoT Core #38020

thaJeztah commented Oct 11, 2018

thaJeztah Oct 11, 2018

lowenna Oct 11, 2018

thaJeztah commented Oct 11, 2018

lowenna commented Oct 11, 2018

thaJeztah commented Oct 11, 2018

darstahl commented Oct 11, 2018

codecov bot commented Oct 12, 2018 •

edited

Loading

lowenna commented Oct 12, 2018

lowenna commented Nov 14, 2018

jiria commented Nov 14, 2018

thaJeztah commented Nov 14, 2018

thaJeztah commented Apr 2, 2019

thaJeztah commented Jul 14, 2019 •

edited

Loading

thaJeztah commented Jul 14, 2019

lowenna left a comment

cpuguy83 left a comment

Remove skip evaluation of symlinks to data root on IoT Core #38020

Remove skip evaluation of symlinks to data root on IoT Core #38020

Conversation

thaJeztah commented Oct 11, 2018

thaJeztah Oct 11, 2018

Choose a reason for hiding this comment

lowenna Oct 11, 2018

Choose a reason for hiding this comment

thaJeztah commented Oct 11, 2018

lowenna commented Oct 11, 2018

thaJeztah commented Oct 11, 2018

darstahl commented Oct 11, 2018

codecov bot commented Oct 12, 2018 • edited Loading

Codecov Report

lowenna commented Oct 12, 2018

lowenna commented Nov 14, 2018

jiria commented Nov 14, 2018

thaJeztah commented Nov 14, 2018

thaJeztah commented Apr 2, 2019

thaJeztah commented Jul 14, 2019 • edited Loading

thaJeztah commented Jul 14, 2019

lowenna left a comment

Choose a reason for hiding this comment

cpuguy83 left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 12, 2018 •

edited

Loading

thaJeztah commented Jul 14, 2019 •

edited

Loading