Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API version to v1.40 #38089

Merged
merged 3 commits into from
Oct 27, 2018
Merged

Update API version to v1.40 #38089

merged 3 commits into from
Oct 27, 2018

Conversation

thaJeztah
Copy link
Member

Some features were merged after API v1.39 shipped as part of the Docker 18.09 betas; this PR updates the API version to 1.40, and corrects the minimal API version for those features.

- Description for the changelog

+ Update API version to 1.40 [moby/moby#38089](https://github.com/moby/moby/pull/38089)

- A picture of a cute animal (not mandatory but encouraged)

cute_owl_by_helmuttt-dahymkr

image: "Cute Owl by HELMUTTT"

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This feature was added in 14da20f,
and was merged after API v1.39 shipped as part of the Docker 18.09
release candidates.

This commit moves the feature to the correct API version.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This feature was added in 514ce73,
and was merged after API v1.39 shipped as part of the Docker 18.09

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @AkihiroSuda (sorry, this will conflict with #38003) @vdemeester

Copy link
Member

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

@thaJeztah
Copy link
Member Author

Windows RS5 seems to be really broken;

14:05:08 INFO: Docker images of the daemon under test
14:05:08 
14:05:08 REPOSITORY          TAG                 IMAGE ID            CREATED             SIZE
14:05:08 
14:05:08 INFO: Base image for tests is microsoft/windowsservercore
14:05:08 INFO: Loading windowsservercore .tar from disk into the daemon under test. This may take some time...
14:06:50 
14:06:50 
14:06:50 ERROR: Failed 'ERROR: Failed to load c:\baseimages\windowsservercore.tar into daemon under test' at 10/26/2018 14:06:50
14:06:50 At C:\gopath\src\github.com\docker\docker\hack\ci\windows.ps1:705 char:21
14:06:50 + ...             Throw $("ERROR: Failed to load $readBaseFrom`:\baseimages ...
14:06:50 +                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
14:06:50 

Copy link
Member

@yongtang yongtang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member Author

yeah, let's merge; the RS5 issue is definitely not related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants