Use original process spec for execs

[crosbymichael]

Fixes #38865

Signed-off-by: Michael Crosby crosbymichael@gmail.com

[crosbymichael]

I have a dream that one day I'll make a PR to this repo and the tests will just pass instead of fail for some stupid reason

[cpuguy83]

Definitely seems to be some regressions after the last swarmkit vendor update.

[thaJeztah]

this is an odd one; https://jenkins.dockerproject.org/job/Docker-PRs-experimental/44458/console does that use exec (and no permissions because of this change?)

20:44:29 --- FAIL: TestTemplatedSecret (3.06s)
20:44:29     secret_test.go:221: Creating a new daemon
20:44:29     daemon.go:288: [da0323621fe41] waiting for daemon to start
20:44:29     daemon.go:320: [da0323621fe41] daemon started
20:44:29     secret_test.go:391: assertion failed: string "error injecting secret: open /go/src/github.com/docker/docker/bundles/test-integration/da0323621fe41/root/containers/e06dc8932fc969f6a5af2faa0ec942560f1d871ac9d32973318b019efaa569c5/mounts/secrets/wennbwjreg8g23oji16kxoiyj: read-only file system\r\n" does not contain "SERVICE_NAME=svc_TestTemplatedSecret\nthis is a secret\nthis is a config\n"
20:44:29     daemon.go:275: [da0323621fe41] exiting daemon

[thaJeztah]

Error comes from here

moby/daemon/container_operations_unix.go

Lines 209 to 211 in cbb885b

	if err := ioutil.WriteFile(fPath, secret.Spec.Data, s.File.Mode); err != nil {
	return errors.Wrap(err, "error injecting secret")
	}

[codecov]

Codecov Report

❗ No coverage uploaded for pull request base (master@6daf5ab). Click here to learn what that means.
The diff coverage is 0%.

@@            Coverage Diff            @@
##             master   #38871   +/-   ##
=========================================
  Coverage          ?   36.89%           
=========================================
  Files             ?      614           
  Lines             ?    45382           
  Branches          ?        0           
=========================================
  Hits              ?    16742           
  Misses            ?    26348           
  Partials          ?     2292

[cpuguy83]

LGTM

[thaJeztah]

LGTM, thanks!

[cpuguy83]

:( Looks like some real CI failures.

[Random-Liu]

Are we going to get this into docker 18.09.4?

[crosbymichael]

Looks like some timeouts on the CI right now

[crosbymichael]

I think this is good to go now, rs5-process seems to be having some unrelated issues

[thaJeztah]

LGTM, thanks 🤗

[yongtang]

All tests passed 🎉