Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distribution: update warning for deprecated image formats #46137

Merged
merged 2 commits into from
Aug 21, 2023

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Aug 1, 2023

distribution: update warning for deprecated image formats

  • Use the same warning for both "v1 in manifest-index" and bare "v1" images.
  • Update URL to use a "/go/" redirect, which allows the docs team to more
    easily redirect the URL to relevant docs (if things move).

distribution: show image schema deprecation on all registries

When we added this deprecation warning, some registries had not yet
moved away from the deprecated specification, so we made the warning
conditional for pulling from Docker Hub.

That condition was added in 647dfe9,
which is over 4 Years ago, which should be time enough for images
and registries to have moved to current specifications.

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

- Use the same warning for both "v1 in manifest-index" and bare "v1" images.
- Update URL to use a "/go/" redirect, which allows the docs team to more
  easily redirect the URL to relevant docs (if things move).

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
When we added this deprecation warning, some registries had not yet
moved away from the deprecated specification, so we made the warning
conditional for pulling from Docker Hub.

That condition was added in 647dfe9,
which is over 4 Years ago, which should be time enough for images
and registries to have moved to current specifications.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review August 18, 2023 15:38
@neersighted neersighted mentioned this pull request Aug 21, 2023
26 tasks
@cpuguy83 cpuguy83 merged commit fc15e08 into moby:master Aug 21, 2023
102 checks passed
@thaJeztah thaJeztah deleted the v1_deprecation branch August 21, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants