fix for issue 7281 #7489
Merged
fix for issue 7281 #7489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Ping @SvenDowideit @fredlf @ostezer |
| @@ -164,6 +164,11 @@ any point in an image's history, much like source control. | |||
| The *exec* form makes it possible to avoid shell string munging, and to `RUN` | |||
| commands using a base image that does not contain `/bin/sh`. | |||
|
|
|||
| > **Note**: | |||
| > To use a different shell, other than '/bin/sh', use the *exec* form | |||
| > passing in the desired shell. For example | |||
There was a problem hiding this comment.
We shall have a comma after "For example" here.
|
LGTM - bar one minor issue. |
add missing comma per O.S. Tezer's commment Signed-off-by: Doug Davis <dug@us.ibm.com>
|
Added missing comma per ostezer's comment |
|
Doesn't this work too:
|
|
It is a lot of overhead to run a command. Setting bash as default would save a lot of typing. |
|
@soerendip you're commenting on a 7 year old pull request. Docker 1.12 and up (pull request: #22489) support a FROM ubuntu
SHELL ["/bin/bash", "-c"]
RUN help | head -1docker build -t foo --no-cache --progress=plain
...
#5 [2/2] RUN help | head -1
#5 sha256:07488e76fa7474eb7789fdc6bf1e9f5575917d00867c2e8b7314bdeea67be8cf
#5 0.336 GNU bash, version 5.0.17(1)-release (x86_64-pc-linux-gnu)
#5 DONE 0.5s |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doug Davis dug@us.ibm.com