Skip to content

Conversation

@tonistiigi
Copy link
Member

@tonistiigi tonistiigi commented Nov 25, 2025

Removes the need for replace rules from forks.

ref sigstore/sigstore-go#543

Removes the need for replace rules from forks.

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
module github.com/moby/policy-helpers

go 1.24.3
go 1.25.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

iiuc this is coming from https://github.com/letsencrypt/boulder/pull/8364/files#r2286329998 , while we don't even import boulder in any code path 🤦

cc @thaJeztah

Copy link
Member

@thaJeztah thaJeztah Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh... perhaps we should ask them why they're forcing go1.25; looks like it was just to reduce their CI matrix for no clear reason.

while we don't even import boulder in any code path 🤦

Yeah; go modules doesn't care if you use it or not; if a dependency is listed anywhere, it's used as part of version resolution;

go mod graph | grep 'github.com/letsencrypt/boulder'
github.com/sigstore/rekor@v1.4.3 github.com/letsencrypt/boulder@v0.0.0-20240620165639-de9c06129bec
github.com/sigstore/rekor-tiles/v2@v2.0.1 github.com/letsencrypt/boulder@v0.0.0-20240620165639-de9c06129bec
github.com/sigstore/sigstore@v1.10.0 github.com/letsencrypt/boulder@v0.20251110.0
github.com/sigstore/sigstore-go@v1.1.4-0.20251124094504-b5fe07a5a7d7 github.com/letsencrypt/boulder@v0.20251110.0
github.com/sigstore/timestamp-authority/v2@v2.0.2 github.com/letsencrypt/boulder@v0.20251110.0
github.com/theupdateframework/go-tuf/v2@v2.3.0 github.com/letsencrypt/boulder@v0.0.0-20240620165639-de9c06129bec

I tried to convince the Go maintainers to prune before resolving, but that was rejected;

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tonistiigi tonistiigi requested a review from crazy-max December 2, 2025 01:07
@tonistiigi tonistiigi merged commit 319fbb9 into moby:main Dec 2, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants