Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updater: Check entire service spec when deciding whether to replace ongoing update #1497

Merged
merged 1 commit into from
Sep 6, 2016
Merged

updater: Check entire service spec when deciding whether to replace ongoing update #1497

merged 1 commit into from
Sep 6, 2016

Commits on Sep 6, 2016

  1. updater: Check entire service spec when deciding whether to replace o… 

    …ngoing update

Currently, updater checks isServiceDirty to decide whether an existing
update should be restarted. This only checks the task spec and the
endpoint spec, so it will ignore changes to fields like UpdateConfig.
For example, it's not possible to change just the parallelism while an
update is already in progress. Fix this by comparing the whole spec.

Signed-off-by: Aaron Lehmann <aaron.lehmann@docker.com>
    @aaronlehmann
    aaronlehmann committed Sep 6, 2016
    Configuration menu
    Copy the full SHA
    f2ba23b View commit details
    Browse the repository at this point in the history