Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raft/transport: add log message to indicate message send retry if streaming unimplemented #2483

Merged
merged 1 commit into from
Jan 9, 2018
Merged

raft/transport: add log message to indicate message send retry if streaming unimplemented #2483

merged 1 commit into from
Jan 9, 2018

Conversation

anshulpundir
Copy link
Contributor

No description provided.

@anshulpundir
raft/transport: add log message to indicate message send retry if str…
17ad7d7 
…eaming unimplemented.

Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
@codecov
Copy link

codecov bot commented Jan 9, 2018 •
edited
Loading

Codecov Report

Merging #2483 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #2483      +/-   ##
==========================================
+ Coverage   61.66%   61.71%   +0.04%     
==========================================
  Files         129      129              
  Lines       21243    21244       +1     
==========================================
+ Hits        13100    13110      +10     
+ Misses       6745     6734      -11     
- Partials     1398     1400       +2

thaJeztah
thaJeztah approved these changes Jan 9, 2018
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

we may want to consider backporting this to EE (may be helpful when debugging issues)

nishanttotla
nishanttotla approved these changes Jan 9, 2018
View reviewed changes
Copy link
Contributor

@nishanttotla nishanttotla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nit: Should the message also state that "streaming unimplemented" was detected?

@anshulpundir
Copy link
Contributor Author

Nit: Should the message also state that "streaming unimplemented" was detected?

This is logged here https://github.com/docker/swarmkit/pull/2483/files#diff-bc30ab801b52865fb8c661eaf57a7bfcR233

@nishanttotla
Copy link
Contributor

This is logged here https://github.com/docker/swarmkit/pull/2483/files#diff-bc30ab801b52865fb8c661eaf57a7bfcR233

fair enough

@nishanttotla nishanttotla merged commit 7560864 into moby:master Jan 9, 2018
@yongtang yongtang mentioned this pull request Jan 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nishanttotla nishanttotla nishanttotla approved these changes

@thaJeztah thaJeztah thaJeztah approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anshulpundir @nishanttotla @thaJeztah