[manager/dispatcher] Synchronize Dispatcher.Stop() with incoming rpcs. #2498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anshul Pundir <anshul.pundir@docker.com>
anshulpundir
force-pushed
the
backport
branch
from
5552fb2
to
b693c86
Compare
|
@andrewhsu We spoke about this two days ago. This is for LMK when you want us to merge this. |
Codecov Report
@@ Coverage Diff @@
## bump_v17.06 #2498 +/- ##
==============================================
- Coverage 64.5% 60.8% -3.71%
==============================================
Files 59 120 +61
Lines 8762 20001 +11239
==============================================
+ Hits 5652 12161 +6509
- Misses 2534 6499 +3965
- Partials 576 1341 +765 |
|
Linking the original PR for discoverability; #2495 |
stevvooe
approved these changes
Feb 3, 2018
|
thanks! I’ll merge so that we can bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git cherry-pick 0b2778a
Cherry pick was clean, with negligible conflict resolution