-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move boltdb/bolt to go.etcd.io/bbolt #2748
Conversation
Signed-off-by: John Howard <jhoward@microsoft.com>
Codecov Report
@@ Coverage Diff @@
## master #2748 +/- ##
==========================================
+ Coverage 61.77% 61.78% +0.01%
==========================================
Files 134 134
Lines 21890 21890
==========================================
+ Hits 13522 13525 +3
+ Misses 6911 6902 -9
- Partials 1457 1463 +6 |
ping @yongtang - PTAL. Thanks :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as boltdb/bolt has been archived now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (not a maintainer)
ping @dperny @anshulpundir PTAL |
This also brings in these PRs from swarmkit: - moby/swarmkit#2691 - moby/swarmkit#2744 - moby/swarmkit#2732 - moby/swarmkit#2729 - moby/swarmkit#2748 Signed-off-by: Tibor Vass <tibor@docker.com>
This also brings in these PRs from swarmkit: - moby/swarmkit#2691 - moby/swarmkit#2744 - moby/swarmkit#2732 - moby/swarmkit#2729 - moby/swarmkit#2748 Signed-off-by: Tibor Vass <tibor@docker.com> Upstream-commit: cce1763d57b5c8fc446b0863517bb5313e7e53be Component: engine
Signed-off-by: John Howard jhoward@microsoft.com
There's a bunch of PRs in various moby and docker related repos, but essentially this to get all the components in moby/moby which are using the unmaintained boltdb/bolt database, which has a bug on Windows, moved to the current maintained fork: specifically release v1.3.1-etcd.8 of go.etcd.io.
moby/moby#37843 has links to the related PRs. Once all related ones are merged, it will resolve this comment: moby/moby#37843 (comment))
@thaJeztah PTAL.