Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CSI plugin load issue (plugin does not implement PluginAddr) #3181

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

blib
Copy link
Contributor

@blib blib commented Sep 8, 2024

CSI plugin does not implement plugin.PluginAddr interface so plugin manager will not load any CSI plugins at all. (see agent/csi/plugin/csi/manager.go:111)

Basicly preventing load of any CSI plugin with following error message volume creation failed: plugin for driver "seaweedfs" does not implement PluginAddr

fixes hetznercloud/csi-driver#680
moby/moby#48133

Signed-off-by: Boris Bliznioukov <blib@mail.com>
@blib
Copy link
Contributor Author

blib commented Oct 9, 2024

I wonder is there anybody here...

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@dperny PTAL

@dperny dperny merged commit e8ecf83 into moby:master Oct 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Attempting to create a volume in Docker Swarm fails
3 participants