Upgraded version of Azure/go-ansiterm #27
Conversation
Upgraded version of Azure/go-ansiterm from v0.0.0-20170929234023-d6e3b3328b78 to v0.0.0-20210608035416-43c61cb656b4 which fixes issue moby#26, kubernetes/kubernetes#102404 and docker/for-win#9770 Latest version of go-ansiterm is compatible with the stdin, stdout and stderr flags passed to `winterm.GetStdFile` function from package `golang.org/x/sys/windows` and it's also backwards compatible with `syscall` package as well Signed-off-by: n4j <neerajx86@gmail.com>
|
@tonistiigi , @thaJeztah , @kolyshkin Can anyone of you please review this request? This is the PR which fixes the issues mentioned in the PR comments |
|
Full diff: Azure/go-ansiterm@d6e3b33...43c61cb Thanks! I actually had docker/cli#2911 (same issue) open in my browser to look at this code |
|
Hmmm... I think there's a bug in Azure/go-ansiterm#31. I don't think that will work as expected; left a comment on that PR Azure/go-ansiterm#31 (review) |
|
Opened Azure/go-ansiterm#32 with a fix |
|
Azure/go-ansiterm#32 was merged; can you update to the latest version of https://github.com/Azure/go-ansiterm ? |
Signed-off-by: n4j <neerajx86@gmail.com>
|
@thaJeztah Done! Thanks for your diligence!!! |
|
New diff is Azure/go-ansiterm@d6e3b33...2377c96 |
|
@cpuguy83 @kolyshkin PTAL |
|
Let's get this one merged; thanks for reviewing @dims |
Upgraded version of Azure/go-ansiterm from
v0.0.0-20170929234023-d6e3b3328b78tov0.0.0-20210608035416-43c61cb656b4which fixes issue #26, kubernetes/kubernetes#102404 and docker/for-win#9770Latest version of go-ansiterm is compatible with the stdin, stdout and stderr flags passed to
winterm.GetStdFilefunction from packagegolang.org/x/sys/windowsand it's also backwards compatible withsyscallpackage as well