Remove util.inspect.custom API

mochajs · Dec 14, 2019 · 25793dd · 25793dd
1 parent d5a0e73
commit 25793dd
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 22 deletions.
diff --git a/lib/reporters/base.js b/lib/reporters/base.js
@@ -9,7 +9,6 @@
 var tty = require('tty');
 var diff = require('diff');
 var milliseconds = require('ms');
-var util = require('util');
 var utils = require('../utils');
 var supportsColor = process.browser ? null : require('supports-color');
 var constants = require('../runner').constants;
@@ -220,9 +219,7 @@ exports.list = function(failures) {
       err = test.err;
     }
     var message;
-    if (typeof err[util.inspect.custom] === 'function') {
-      message = util.inspect(err) + '';
-    } else if (typeof err.inspect === 'function') {
+    if (typeof err.inspect === 'function') {
       message = err.inspect() + '';
     } else if (err.message && typeof err.message.toString === 'function') {
       message = err.message + '';

diff --git a/test/reporters/base.spec.js b/test/reporters/base.spec.js
@@ -2,7 +2,6 @@
 
 var assert = require('assert');
 var chai = require('chai');
-var util = require('util');
 var sinon = require('sinon');
 var helpers = require('./helpers');
 var reporters = require('../../').reporters;
@@ -377,22 +376,7 @@ describe('Base reporter', function() {
     expect(errOut, 'to be', '1) test title:\n     Error\n  foo\n  bar');
   });
 
-  it("should use 'util.inspect.custom' if err is including util.inspect.custom parameter", function() {
-    var err = new Error('test');
-    err.showDiff = false;
-    err[util.inspect.custom] = function() {
-      return 'Custom Formatted Error';
-    };
-
-    var test = makeTest(err);
-
-    list([test]);
-
-    var errOut = stdout.join('\n').trim();
-    expect(errOut, 'to contain', 'Custom Formatted Error');
-  });
-
-  it("should use 'inspect' if 'util.inspect.custom' is not set", function() {
+  it("should use 'inspect' if err include 'inspect' parameter", function() {
     var err = new Error('test');
     err.showDiff = false;
     err.inspect = function() {
@@ -408,7 +392,7 @@ describe('Base reporter', function() {
     expect(errOut, 'to contain', 'Inspect Error');
   });
 
-  it("should set an empty message if 'util.inspect.custom' and 'inspect' and 'message' is not set", function() {
+  it("should set an empty message if neither 'inspect' nor 'message' is set", function() {
     var err = {
       showDiff: false
     };