Skip to content

Commit

Permalink
Drop node.js v8 support
Browse files Browse the repository at this point in the history
Related #4163
  • Loading branch information
UlisesGascon authored and juergba committed Feb 3, 2020
1 parent 883ae4b commit 4a53713
Show file tree
Hide file tree
Showing 7 changed files with 9 additions and 16 deletions.
4 changes: 2 additions & 2 deletions .eslintrc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ overrides:
- test/integration/helpers.js
- lib/growl.js
parserOptions:
ecmaVersion: 2017
ecmaVersion: 2018
env:
browser: false

Expand Down Expand Up @@ -76,7 +76,7 @@ overrides:
- files:
- test/**/*.mjs
parserOptions:
ecmaVersion: 2017
ecmaVersion: 2018
sourceType: module

- files:
Expand Down
2 changes: 1 addition & 1 deletion .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ Follow these steps to get going. If you are having trouble, don't be afraid to [

> PRO TIP: After `npm install`, run `npm start` to see a list of commands which can be run with `npm start <command>` (powered by [nps](https://npm.im/nps)).
1. [Install Node.js 8.x or newer](https://nodejs.org/en/download/).
1. [Install Node.js 10.x or newer](https://nodejs.org/en/download/).
- If you're new to installing Node, a tool like [nvm](https://github.com/creationix/nvm#install-script) can help you manage multiple version installations.
- You will need [Google Chrome](https://www.google.com/chrome/) to run browser-based tests locally.
1. Follow [Github's documentation](https://help.github.com/articles/fork-a-repo/) on setting up Git, forking and cloning.
Expand Down
6 changes: 0 additions & 6 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -46,9 +46,6 @@ jobs:
- <<: *node
node_js: '10'

- <<: *node
node_js: '8'

- script: npm start test.bundle test.browser
# XXX: update when canvas supplies a prebuilt binary for Node.js v12.x
node_js: 10
Expand Down Expand Up @@ -83,9 +80,6 @@ jobs:
- <<: *smoke
node_js: '10'

- <<: *smoke
node_js: '8'

- stage: precache
script: true

Expand Down
1 change: 0 additions & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ environment:
- nodejs_version: '13'
- nodejs_version: '12'
- nodejs_version: '10'
- nodejs_version: '8'
matrix:
fast_finish: true
install:
Expand Down
2 changes: 1 addition & 1 deletion docs/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ _So you wanna build the site?_

## Prerequisites

- Node.js v8.x or greater
- Node.js v10.x or greater

## Development

Expand Down
8 changes: 4 additions & 4 deletions docs/index.md
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ or as a development dependency for your project:
$ npm install --save-dev mocha
```

> As of v7.0.0, Mocha requires Node.js v8.0.0 or newer.
> As of v8.0.0, Mocha requires Node.js v10.0.0 or newer.
## Getting Started

Expand Down Expand Up @@ -1608,17 +1608,17 @@ mocha.setup({

### Browser-specific Option(s)

Browser Mocha supports many, but not all [cli options](#command-line-usage).
Browser Mocha supports many, but not all [cli options](#command-line-usage).
To use a [cli option](#command-line-usage) that contains a "-", please convert the option to camel-case, (eg. `check-leaks` to `checkLeaks`).

#### Options that differ slightly from [cli options](#command-line-usage):

`reporter` _{string|constructor}_
`reporter` _{string|constructor}_
You can pass a reporter's name or a custom reporter's constructor. You can find **recommended** reporters for the browser [here](#reporting). It is possible to use [built-in reporters](#reporters) as well. Their employment in browsers is neither recommended nor supported, open the console to see the test results.

#### Options that _only_ function in browser context:

`noHighlighting` _{boolean}_
`noHighlighting` _{boolean}_
If set to `true`, do not attempt to use syntax highlighting on output test code.

### Reporting
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
"test": "./test"
},
"engines": {
"node": ">= 8.0.0"
"node": ">= 10.0.0"
},
"scripts": {
"prepublishOnly": "nps test clean build",
Expand Down

0 comments on commit 4a53713

Please sign in to comment.