coerce function for boolean/string/number types

mochajs · May 2, 2019 · bea695b · bea695b
1 parent f5ca468
commit bea695b
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 16 deletions.
diff --git a/lib/cli/options.js b/lib/cli/options.js
@@ -54,15 +54,26 @@ const configuration = Object.assign({}, YARGS_PARSER_CONFIG, {
 });
 
 /**
- * This is a really fancy way to ensure unique values for `array`-type
- * options.
+ * This is a really fancy way to ensure
+ * - unique values for `array`-type options
+ * - for non-`array`-type options given multiple times, use its array's last element
  * This is passed as the `coerce` option to `yargs-parser`
  * @private
  * @ignore
  */
-const coerceOpts = types.array.reduce(
-  (acc, arg) => Object.assign(acc, {[arg]: v => Array.from(new Set(list(v)))}),
-  {}
+const coerceOpts = Object.assign(
+  types.array.reduce(
+    (acc, arg) =>
+      Object.assign(acc, {[arg]: v => Array.from(new Set(list(v)))}),
+    {}
+  ),
+  types.boolean
+    .concat(types.string, types.number)
+    .reduce(
+      (acc, arg) =>
+        Object.assign(acc, {[arg]: v => (Array.isArray(v) ? v.pop() : v)}),
+      {}
+    )
 );
 
 /**

diff --git a/lib/cli/run.js b/lib/cli/run.js
@@ -258,13 +258,6 @@ exports.builder = yargs =>
         }
       });
 
-      types.boolean
-        .concat(types.string, types.number)
-        .filter(opt => Array.isArray(argv[opt]))
-        .forEach(opt => {
-          argv[opt] = argv[opt].pop();
-        });
-
       // yargs.implies() isn't flexible enough to handle this
       if (argv.invert && !('fgrep' in argv || 'grep' in argv)) {
         throw createMissingArgumentError(

diff --git a/test/node-unit/cli/options.spec.js b/test/node-unit/cli/options.spec.js
@@ -83,7 +83,7 @@ describe('options', function() {
             config: false,
             opts: false,
             package: false,
-            retries: 3
+            retries: '3'
           })
         );
       });
@@ -199,7 +199,7 @@ describe('options', function() {
                   config: false,
                   opts: false,
                   package: false,
-                  retries: 3
+                  retries: '3'
                 }
               )
             );
@@ -424,7 +424,7 @@ describe('options', function() {
                 config: false,
                 opts: false,
                 package: false,
-                retries: 3
+                retries: '3'
               })
             );
           });
@@ -473,7 +473,7 @@ describe('options', function() {
                 config: false,
                 opts: false,
                 package: false,
-                retries: 3
+                retries: '3'
               })
             );
           });