Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove lodash.create for npm < v1.3.7 support #1868

Closed
boneskull opened this issue Sep 7, 2015 · 9 comments · Fixed by gluckgames/pixi-packer#17
Closed

remove lodash.create for npm < v1.3.7 support #1868

boneskull opened this issue Sep 7, 2015 · 9 comments · Fixed by gluckgames/pixi-packer#17
Assignees
@boneskull

Comments

@boneskull
Copy link
Contributor

prompted by #1867
@boneskull boneskull self-assigned this Sep 7, 2015
@boneskull
Copy link
Contributor Author

@dougwilson just gotta update the changelog and publish

@dougwilson
Copy link
Contributor

Thanks, @boneskull . Now that 2.3.2 is finally published, I tried it out, and still no dice: 2.3.2 still does not install. The new version of jade in 2.3.0 now has multiple dependencies with ^: https://github.com/jadejs/jade/blob/1.11.0/package.json#L25-L36

@boneskull
Copy link
Contributor Author

I think instead of reverting the Jade upgrade, it would be best to completely remove the dependency and either:

  1. remove the htmlcov reporter--there are other tools available which generate HTML coverage and probably a lot better than Mocha does
  2. move it to its own repo
  3. make it an optionalDependency

Thoughts?

cc @mochajs/mocha

@dougwilson
Copy link
Contributor

Hi @boneskull , is there any update here?

@dougwilson dougwilson mentioned this issue Sep 11, 2015
Closed
@travisjeffery
Copy link
Contributor

I'm in favor of simply reverting the jade version.

@danielstjules
Copy link
Contributor

Is there any disadvantage to using an older version of jade?

@dougwilson
Copy link
Contributor

As far as I can tell, the jade upgrade was a "just because why not" upgrade (#1811 and #1835).

@boneskull
Copy link
Contributor Author

I thought someone was having a problem with something, but I don't recall what. Feel free to just revert it.

@danielstjules danielstjules mentioned this issue Sep 12, 2015
Merged
@dasilvacontin
Copy link
Contributor

Revert jade as simple solution for now. Looking forward to remove the dependency via extracting reporters in the future.

kevinawoo added a commit to kevinawoo/mocha that referenced this issue Oct 6, 2015
@kevinawoo
Merge branch 'master' into feature/v3.0.0-with-generators
e0272db 
* master: (25 commits)
  Fix mochajs#1798: Correctly attribute mutiple done err with hooks
  Remove redundant harmony flag
  Cast non-string return values from err.inspect()
  Call the inspect() function if message is not set
  Revert jade to support npm < v1.3.7
  Fix eqeqeq linting errors from eslint 1.4.0 release
  Fix mochajs#1669: catch uncaught errors outside test suite execution
  Support all harmony flags
  Fix fragile xunit reporter spec
  Fix linter warning "Expected a conditional expression and instead saw an assignment"
  Stackfilter fix: Don't remove modules/components from stack trace in the browser
  Fix mochajs#1864: xunit missing output with --reporter-options output
  Fix 1875: Markdown reporter exceeds maximum call stack size
  IE<=8 no [].reduce, so use 'utils.reduce' instead
  Release v2.3.2
  remove lodash.create; closes mochajs#1868
  update package.json & component.json for v2.3.1
  update HISTORY.md
  fix package.json to use exact version of lodash; closes mochajs#1867
  Fix: Bail flag causes before() hooks to be run even after a failure
  ...

# Conflicts:
#	lib/runnable.js
@marekventur marekventur mentioned this issue Dec 14, 2015
Merged
@danielstjules danielstjules mentioned this issue Jan 19, 2016
Closed
@renovate renovate bot mentioned this issue Sep 23, 2018
Closed
1 task
@renovate renovate bot mentioned this issue Nov 14, 2018
Merged
This was referenced Dec 29, 2018
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@boneskull boneskull

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update "mocha" to version ~2.3.4 gluckgames/pixi-packer
5 participants
@travisjeffery @dougwilson @danielstjules @boneskull @dasilvacontin