Annotate when exceptions are caught but ignored #3354
Labels
type: cleanup
a refactor
Comments
plroebuck
added a commit
to plroebuck/mocha
that referenced
this issue
Apr 26, 2018
There's an existing convertion to name intentionally ignored errors in catch block as `ignore`. Modified codebase to follow it. Fixes mochajs#3354
boneskull
pushed a commit
that referenced
this issue
May 1, 2018
* style(*various*): Annotate when exceptions are caught but ignored There's an existing convertion to name intentionally ignored errors in catch block as `ignore`. Modified codebase to follow it. Fixes #3354 * style(bin/options.js): Turn off prettier for single line Prettier reformatting is just wrong here. fs.readFileSync() should **not** be split across multiple lines. * Revert "style(bin/options.js): Turn off prettier for single line" This reverts commit eb034dd. * style(bin/options.js): Revert un-Prettier comment per Boneskull's request
boneskull
pushed a commit
that referenced
this issue
May 4, 2018
* style(*various*): Annotate when exceptions are caught but ignored There's an existing convertion to name intentionally ignored errors in catch block as `ignore`. Modified codebase to follow it. Fixes #3354 * style(bin/options.js): Turn off prettier for single line Prettier reformatting is just wrong here. fs.readFileSync() should **not** be split across multiple lines. * Revert "style(bin/options.js): Turn off prettier for single line" This reverts commit eb034dd. * style(bin/options.js): Revert un-Prettier comment per Boneskull's request
boneskull
pushed a commit
that referenced
this issue
May 18, 2018
* style(*various*): Annotate when exceptions are caught but ignored There's an existing convertion to name intentionally ignored errors in catch block as `ignore`. Modified codebase to follow it. Fixes #3354 * style(bin/options.js): Turn off prettier for single line Prettier reformatting is just wrong here. fs.readFileSync() should **not** be split across multiple lines. * Revert "style(bin/options.js): Turn off prettier for single line" This reverts commit eb034dd. * style(bin/options.js): Revert un-Prettier comment per Boneskull's request
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this issue
Feb 27, 2019
…ochajs#3356) * style(*various*): Annotate when exceptions are caught but ignored There's an existing convertion to name intentionally ignored errors in catch block as `ignore`. Modified codebase to follow it. Fixes mochajs#3354 * style(bin/options.js): Turn off prettier for single line Prettier reformatting is just wrong here. fs.readFileSync() should **not** be split across multiple lines. * Revert "style(bin/options.js): Turn off prettier for single line" This reverts commit eb034dd. * style(bin/options.js): Revert un-Prettier comment per Boneskull's request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
There's an existing convention of naming intentionally ignored errors in try/catch as
ignore. Modify codebase to follow it.The text was updated successfully, but these errors were encountered: