Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove [skip ci] workaround for GitHub Actions #4579

Merged
merged 1 commit into from
Mar 5, 2021

Conversation

outsideris
Copy link
Contributor

Now GH actions officially support [skip ci]. So, we don't need this workaround anymore.

If commit message contains [skip ci], [ci skip], [no ci], [skip actions], or [actions skip], GitHub actions workflow never run. It means there are no logs it was skipped. Just skipped.

@outsideris outsideris added the qa label Feb 20, 2021
@outsideris outsideris changed the title Remove [skip ci] workaround for GitHub Action Remove [skip ci] workaround for GitHub Actions Feb 20, 2021
@outsideris
Copy link
Contributor Author

I rollbacked the code to prevent running ci twice from both push and pull_request events.

Push event ran CI: https://github.com/mochajs/mocha/actions/runs/624447871
Pull request event skipped: https://github.com/mochajs/mocha/actions/runs/624447921

@juergba juergba added the semver-patch implementation requires increase of "patch" version number; "bug fixes" label Mar 5, 2021
@juergba juergba added this to the next milestone Mar 5, 2021
@juergba juergba merged commit e29c2f4 into master Mar 5, 2021
@juergba juergba deleted the outsider-remove-skip-ci branch March 7, 2021 09:17
This was referenced Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch implementation requires increase of "patch" version number; "bug fixes"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants