-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove [skip ci] workaround for GitHub Actions #4579
Merged
Merged
+4
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
changed the title
Remove [skip ci] workaround for GitHub Action
Remove [skip ci] workaround for GitHub Actions
Feb 20, 2021
juergba
reviewed
Feb 20, 2021
ref: https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/ Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
outsider-remove-skip-ci
branch
from
March 5, 2021 12:47
613e199
to
8112d9e
Compare
I rollbacked the code to prevent running ci twice from both push and pull_request events. Push event ran CI: https://github.com/mochajs/mocha/actions/runs/624447871 |
juergba
approved these changes
Mar 5, 2021
juergba
added
the
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
label
Mar 5, 2021
This was referenced Mar 6, 2021
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now GH actions officially support [skip ci]. So, we don't need this workaround anymore.
If commit message contains
[skip ci]
,[ci skip]
,[no ci]
,[skip actions]
, or[actions skip]
, GitHub actions workflow never run. It means there are no logs it was skipped. Just skipped.