Mocha Json reporter references the incorrect variable for reporterOptions

[KamalAman]

The reporter references are variable called reporterOption however there is no such thing, it is reporterOptions with an s at the end of it

mocha/lib/reporters/json.js

Line 47 in 4860738

if (options.reporterOption && options.reporterOption.output) {

Added in 4607
Requested in 4131

[juergba]

@KamalAman I don't think so.
https://github.com/mochajs/mocha/blob/master/lib/mocha.js#L202

[KamalAman]

@juergba Interesting, yeah things seem to be inconsistent. While mocha.js does define reporterOption no other reporter actually uses that.

These 3 reporters use reporterOptions

mocha/lib/reporters/progress.js

Line 51 in 4860738

var reporterOptions = options.reporterOptions || {};

mocha/lib/reporters/tap.js

Line 44 in 4860738

if (options && options.reporterOptions) {

mocha/lib/reporters/xunit.js

Line 58 in 4860738

if (options && options.reporterOptions) {

[KamalAman]

@juergba please reopen, see my comment above

Another FYI, Cypress has also integrated with reporterOptions and not reporterOption
https://github.com/cypress-io/cypress/blob/a6a2c49c353d692e0009018a3fa186f164bc4730/packages/server/lib/reporter.js#L293

[juergba]

It works with the canonical name reporterOptionand its alias name reporterOptions, with both names.
You haven't really tested,right?

[KamalAman]

I have with Cypress. Since it should be an alias parameters, then Cypress has a bug with their integration.
Thanks