Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding tests for exit codes #1339

Merged
merged 0 commits into from
Oct 17, 2014
Merged

adding tests for exit codes #1339

merged 0 commits into from
Oct 17, 2014

Conversation

boneskull
Copy link
Contributor

I rebased this branch (fix/333) against master, and added tests for #1297 in 7c4ba93.

@travisjeffery If you're happy with dc8fcf6, I will go ahead and merge it all into master.

@jbnicolai
Copy link

I rebased this branch (fix/333) against master, and added tests for #1297 in 7c4ba93.

Wouldn't it have been cleaner to consider the rebase onto master (which is a good thing of itself!) and the extra test two separate issues?

  1. rebase visionmedia:fix/333 on top of visionmedia:master and force push
  2. branch of visionmedia:fix/333 to boneskull:fix/333
  3. commit the test
  4. create this pr, boneskull:fix/333 -> visionmedia:fix/333

Because right now there's a needlessly huge diff which I can't really read or understand 😉

@boneskull
Copy link
Contributor Author

@jbnicolai I was having problems getting the test working w/o the rebase.

Anyway, I could do that, or I could just tell you that the only changesets you would be interested in are:

If this is insufficient let me know.

@jbnicolai jbnicolai mentioned this pull request Sep 7, 2014
@jbnicolai
Copy link

Was only telling you because that workflow would've been easier for you as well ;-), see the referenced PR above this comment for an example.

@jbnicolai
Copy link

Other than that it looks good to me 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants