Added option to allow unhandled exceptions to propagate in the browser #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This results in a slight change to the behavior of --async-only: instead of failing immediately, check to see if the test returned a promise (or otherwise failed) before complaining about not having a done callback.
* commit '7657cb11d960cf2cd8407b256019b2e34dc93328': Allow --async-only to be satisfied by returning a promise
|
+1 |
|
I don't get it. Why don't we just do both? |
|
@boneskull now it does 👍 |
|
@mochajs/mocha seems like a good idea to me for minor release. if there is no disagreement I will merge this |
|
@amsul can you rebase on top of branch |
|
@boneskull done |
|
lgtm. |
Show string diff as a raw data, this fix issue mochajs#1241.
added tests for allowUncaught option error handler prints to dom with allowUncaught
This results in a slight change to the behavior of --async-only: instead of failing immediately, check to see if the test returned a promise (or otherwise failed) before complaining about not having a done callback.
fixed merge issues fixed merge issues fixed merge issues
|
@amsul I don't think you can actually change which branch you're making a PR against, so you may want to actually open a new one. I'm going to close this to make sure it doesn't get accidentally merged.
Thanks! |
boneskull
added a commit
that referenced
this pull request
May 9, 2015
Added option to allow unhandled exceptions to propagate in the browser (rel #1659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #553
This adds the
mocha.allowUncaughtmethod.When the method isn’t invoked, the console is empty:
When the method is invoked, the console shows the unhandled exception: