Fixes tests in windows (fixed #1813) #1814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 thanks, I'll review asap :) |
tswaters
force-pushed
the
master
branch
2 times, most recently
from
5b325c8
to
1cf2f60
Compare
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
May 22, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. Changes from mochajs#1814 include: - Rebasing - Use process.argv[0] as an authoritative path for Node.js executable - Support having spaces in path of Node.js executable - Avoid external dependencies for child_process.spawn() - Fix symlink tests on Windows. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
|
I fixed a few additional things and rebased the commit in #2270. |
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
May 22, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. Changes from mochajs#1814 include: - Rebasing - Use process.argv[0] as an authoritative path for Node.js executable - Support having spaces in path of Node.js executable - Avoid external dependencies for child_process.spawn() - Fix symlink tests on Windows. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
May 23, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. Changes from mochajs#1814 include: - Rebasing - Use process.argv[0] as an authoritative path for Node.js executable - Support having spaces in path of Node.js executable - Avoid external dependencies for child_process.spawn() - Fix symlink tests on Windows. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
|
@TimothyGu thanks for this! we will need to rebase again tho |
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
Jun 11, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. Changes from mochajs#1814 include: - Rebasing - Use process.argv[0] as an authoritative path for Node.js executable - Support having spaces in path of Node.js executable - Avoid external dependencies for child_process.spawn() - Fix symlink tests on Windows. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
|
@boneskull, I checked my PR, and GitHub says that there are no conflicts. But nevertheless I rebased and force pushed just to make sure everything works. |
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
Jun 14, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. This commit contains the following changes: - Add quotation marks to Makefile variables for programs. The variables use POSIX-style paths, which cannot be used on Windows to launch a program except when quoted. Using double quotation marks instead of single since the latter is not available on Windows - Use os-tmpdir module to get an acceptable directory for temporary usage instead of relying on the POSIX /tmp - Use process.execPath as an authoritative path for Node.js executable - Detect whether symbol links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions - Fix hook tests. The tests parse output of the "dot" reporter to separate output of individual tests. The "dot" reporter uses "·" symbol (U+2024 ONE DOT LEADER) under POSIX environments and "." symbol (U+002E FULL STOP) under Windows, which means that having "." in the echoed message makes it ambiguous to be parsed in Windows. To fix this issue, two separate changes are necessary: - Use a dynamically created regular expression to split the tests based on the specific dot character used on the platform - Replace "." with "-" in echoed messages in fixtures for hook tests to avoid ambiguity with the character output by the reporter Changes from mochajs#1814 include: - Rebasing - Use process.execPath as an authoritative path for Node.js executable - Avoid external dependencies for child_process.spawn() - Detect whether symbol links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
TimothyGu
added a commit
to TimothyGu/mocha
that referenced
this pull request
Jun 14, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in mochajs#1814. This commit contains the following changes: - Add quotation marks to Makefile variables for programs. The variables use POSIX-style paths, which cannot be used on Windows to launch a program except when quoted. Using double quotation marks instead of single since the latter is not available on Windows - Use os-tmpdir module to get an acceptable directory for temporary usage instead of relying on the POSIX /tmp - Use process.execPath as an authoritative path for Node.js executable - Detect whether symbolic links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions - Fix hook tests. The tests parse output of the "dot" reporter to separate output of individual tests. The "dot" reporter uses "·" symbol (U+2024 ONE DOT LEADER) under POSIX environments and "." symbol (U+002E FULL STOP) under Windows, which means that having "." in the echoed message makes it ambiguous to be parsed in Windows. To fix this issue, two separate changes are necessary: - Use a dynamically created regular expression to split the tests based on the specific dot character used on the platform - Replace "." with "-" in echoed messages in fixtures for hook tests to avoid ambiguity with the character output by the reporter Changes from mochajs#1814 include: - Rebasing - Use process.execPath as an authoritative path for Node.js executable - Avoid external dependencies for child_process.spawn() - Detect whether symbol links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions Fixes mochajs#1813.
|
Closing in favour of #2270 – Thanks! |
boneskull
pushed a commit
that referenced
this pull request
Jun 29, 2016
Based on work by Tyler Waters <tyler.waters@gmail.com> in #1814. This commit contains the following changes: - Add quotation marks to Makefile variables for programs. The variables use POSIX-style paths, which cannot be used on Windows to launch a program except when quoted. Using double quotation marks instead of single since the latter is not available on Windows - Use os-tmpdir module to get an acceptable directory for temporary usage instead of relying on the POSIX /tmp - Use process.execPath as an authoritative path for Node.js executable - Detect whether symbolic links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions - Fix hook tests. The tests parse output of the "dot" reporter to separate output of individual tests. The "dot" reporter uses "·" symbol (U+2024 ONE DOT LEADER) under POSIX environments and "." symbol (U+002E FULL STOP) under Windows, which means that having "." in the echoed message makes it ambiguous to be parsed in Windows. To fix this issue, two separate changes are necessary: - Use a dynamically created regular expression to split the tests based on the specific dot character used on the platform - Replace "." with "-" in echoed messages in fixtures for hook tests to avoid ambiguity with the character output by the reporter Changes from #1814 include: - Rebasing - Use process.execPath as an authoritative path for Node.js executable - Avoid external dependencies for child_process.spawn() - Detect whether symbol links are supported on the platform before testing. On Windows, creating symlinks can fail since it needs additional user permissions Fixes #1813.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.