Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature ignore file #2036 #2173

Closed
wants to merge 2 commits into from
Closed

Feature ignore file #2036 #2173

wants to merge 2 commits into from

Conversation

megagon
Copy link

@megagon megagon commented Mar 29, 2016

Please take a look at the implementation.
Let me know if that's ok - i will make tests for this. If need something to change - i will change.
After this i am going to add support to ignore files/suites/folders etc...

Tests passed locally.

@boneskull
Copy link
Contributor

@megagon Hi, thanks for this. As you can see in #2036, nobody replied to your question. We are spread pretty thin at the moment.

I'm not very enthusiastic about adding features at the moment, and we're not going to release until we get some browser coverage. IMO any changes before the rewrite should probably just be bug fixes. But others can weigh in...

cc @mochajs/mocha

@boneskull
Copy link
Contributor

@megagon We do have browser coverage now and have since released, so we can revisit this.

I have a few comments:

  1. The default file should be .mochaignore
  2. It should support a global mochaignore file installed at whatever npm get prefix is
  3. It should support a per-user ~/.mochaignore
  4. It should be based upon ignore as to work how users would expect

Thanks for the PR!

@boneskull boneskull added type: feature enhancement proposal pr-needs-work labels Jun 11, 2016
@ScottFreeCode
Copy link
Contributor

FWIW, I've discovered that you can actually accomplish exclusion, albeit cryptically and not as easily, using Glob with Mocha as-is: #1577 (comment)

@boneskull
Copy link
Contributor

Closing for inactivity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature enhancement proposal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants