Update README's header section #2214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
@dasilvacontin What does "couldn't use" mean? |
|
@boneskull image would display as broken, and opening the svg's url would display the file's raw content (xml tags and such), instead of a render of the svg (like happens when you open one of our badge's svg url) |
|
@dasilvacontin I'm not seeing an example of hosting an |
|
@boneskull I tried imgur but they don't support Btw, the logo with the |
dasilvacontin
force-pushed
the
looks-and-bells
branch
from
54cf525 to
92f8943
Compare
Improves the looks of the README's top/header section: - Updates logo to use the new design, svg hosted on Clodup - Center logo - Gives logo some top/bottom margin
dasilvacontin
force-pushed
the
looks-and-bells
branch
from
92f8943 to
8e34460
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I couldn't use the
.svg's we have in/assets/for some reason, maybe because of the way it was exported. You can try it out for yourselves. /cc @boneskullIf we were to use an image, we need a
@2xexport (double size) for retina screens. Hmm, I can actually generate one of those myself. But I hope we can solve the issues oursvgfiles have.I'll squash (or use "squash & merge") as necessary once the PR is reviewed, just in case we want to easily revert a subset of the changes.