Sets the allowUncaught parameter for hooks. #2303
Conversation
dima117
changed the title
|
@dima117 Thanks! Can you please add a test in |
|
I added a test for allowUncaught parameter in hooks. |
|
Do I need to do something else for this PR? |
|
@boneskull What is the state of this PR? |
|
Is it safe to call |
|
I think yes. Why it may be unsafe? |
|
@dima117 Apologies for not getting to this earlier. |
| @@ -315,6 +315,17 @@ describe('Runner', function(){ | |||
| }); | |||
|
|
|||
| describe('allowUncaught', function() { | |||
| var immediately; | |||
There was a problem hiding this comment.
Why are we monkeypatching Runner.immediately()?
There was a problem hiding this comment.
It was done in order to run the hook synchronously.
There was a problem hiding this comment.
Why do we need to do that?
There was a problem hiding this comment.
We need it to catch the exception in the test method, instead of catching it on a global error handler.
boneskull
added
the
status: waiting for author
|
Hello! What is the status of this PR? |
boneskull
added
status: needs review
|
I may use some of this, though I don't expect the original author to sign a CLA at this point |
|
see #2302 |
#2302