drop support for unmaintained versions of Node.js; upgrade stuff #3017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid fussing about Chai in test files
boneskull
added
the
semver-major
4 tasks
boneskull
force-pushed
the
issue/3016
branch
from
89bb30d to
d6c5bc0
Compare
- allow debug in the browser - use browserify's eventemitter - stub growl
boneskull
changed the title
|
This will be (squashed) and merged when the build's green. |
| @@ -229,7 +229,7 @@ Runner.prototype.fail = function (test, err) { | |||
| ++this.failures; | |||
| test.state = 'failed'; | |||
|
|
|||
| if (!(err instanceof Error || err && typeof err.message === 'string')) { | |||
| if (!((err instanceof Error || err) && typeof err.message === 'string')) { | |||
There was a problem hiding this comment.
Are we sure this shouldn't be if (!(err instanceof Error || (err && typeof err.message === 'string'))) {? Reading the original, and not remembering exactly how JS evaluates differing chained boolean operators without parentheses, it looks like the original included err as a condition to guard against accessing .message of undefined.
There was a problem hiding this comment.
I think you're right.
| _stringify(object[i]) + // value | ||
| (length ? ',' : ''); // comma | ||
| _stringify(object[i]) + // value | ||
| (length ? ',' : ''); // comma |
There was a problem hiding this comment.
[unimportant] I long for the day that linters can recognise when whitespace has been properly used to make things, any things, line up across multiple lines. [/unimportant]
boneskull
added a commit
that referenced
this pull request
Sep 29, 2017
boneskull
added a commit
that referenced
this pull request
Sep 29, 2017
boneskull
added a commit
that referenced
this pull request
Sep 29, 2017
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
…hajs#3017) * remove unmaintained versions of Node.js from CI * ignore test fixtures when linting * upgrade ESLint and its ilk * avoid fussing about Chai in test files * lint * upgrade should * upgrade karma-spec-reporter * upgrade growl and debug * update "engines" field in package.json * fix some bundling issues * allow debug in the browser * use browserify's eventemitter * stub growl
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #3016
growldebugeslintand plugins and sweep up codeshould,growl, anddebugenginesfield inpackage.jsonI'm going to see what else I can squeeze out of this.