add working wallaby config #3224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed at wallabyjs/public#1490 (comment)
|
😍 awesome, can't wait to try this. thanks @ArtemGovorov |
boneskull
approved these changes
Feb 8, 2018
| // to expose it/describe etc. on the mocha under test | ||
| const mochaUnderTest = new (require('./'))(); | ||
| mochaUnderTest.suite.emit('pre-require', global, '', mochaUnderTest); | ||
| // to make test/node-unit/color.spec.js pass, we need to run mocha in the project's folder context |
There was a problem hiding this comment.
@ArtemGovorov how did you figure this out?
There was a problem hiding this comment.
Just had been reading mocha source code and discovered it. Wallaby uses mocha a bit differently from how mocha CLI is using mocha :)
boneskull
added
qa
semver-patch
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Sep 23, 2018
This was referenced Oct 2, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Added Wallaby config file as discussed at wallabyjs/public#1490 (comment).
Alternate Designs
n/a
Why should this be in core?
n/a
Benefits
Mocha contributors who are using Wallaby can continuously run mocha tests.
Possible Drawbacks
n/a
Applicable issues
n/a