add update-contributors script; closes #3289 #3290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
type: chore
outsideris
reviewed
Mar 23, 2018
scripts/update-contributors.js
Outdated
| .sort((a, b) => a.toLowerCase().localeCompare(b.toLowerCase())); | ||
| const newCount = contributors.length; | ||
| const pkgFilepath = path.join(ROOT, 'package.json'); | ||
| const pkg = JSON.parse(fs.readFileSync(pkgFilepath, 'utf8')); |
There was a problem hiding this comment.
How about you just do require(pkgFilepath);?
There was a problem hiding this comment.
In this case, it’s mainly semantic. If I don’t need nor want the caching which require() provides, then I shouldn’t use it. In this script it doesn’t really matter since we don’t use the result elsewhere, but I feel it better illustrates the intent.
There was a problem hiding this comment.
I understood what you mean. :)
Bamieh
approved these changes
Mar 24, 2018
outsideris
approved these changes
Mar 24, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
* add update-contributors script; closes mochajs#3289 * attempt to fix cache issue with npm@2.x Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
contributorsprop ofpackage.jsonand adds tooling to help.This grabs information from Git only. I am working on a better way to ensure more people are recognized, but this is what I have for now. On the plus side, it's very fast.
We lose the GitHub user URLs, but not a big deal IMO.