-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use build stages for Travis CI #3302
Conversation
Coverage change is annoying. I will dig the problem when I have enough time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a ton. i'm going to merge this because I want to fiddle with it.
- stage: lint | ||
node_js: '8' | ||
env: TARGET=lint | ||
script: npm start $TARGET |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am guessing this can be simplified into something like
script: npm start $TARGET
node_js: '9'
jobs:
include:
- stage: lint
env: TARGET=lint
- stage: test # use default node version
env: TARGET=test.node COVERAGE=true
- stage: test
node_js: '8'
env: TARGET=test.node
- stage: test
node_js : '6'
env: TARGET=test.node
see https://docs.travis-ci.com/user/build-stages/#Build-Stages-and-Build-Matrix-Expansion
Description of the Change
Introduce TravisCI build stages; it's still beta to make our builds more obviously and easier to understand. It groups our builds as
lint
ortest.
I run linting first and then run tests because linting is much cheaper than tests.
Alternate Designs
We can add more stages.
For example, we can use a
build
stage insteadbefore_script
or acoverage
stage insteadafter_success
.Why should this be in core?
IMO, it's more obviously, but it's tiny.
I'm not sure that we should use this yet. It's still beta.
Benefits
Easy to understand our build status.
Possible Drawbacks
If there are some bugs in this feature or Travis change something, our build might be broken, or we should update our
.travis.yml
.Applicable issues
#3292