fix circular objects in json reporter; closes #2433 #3318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boneskull
added
area: reporters
outsideris
reviewed
Apr 8, 2018
| return { | ||
| title: test.title, | ||
| fullTitle: test.fullTitle(), | ||
| duration: test.duration, | ||
| currentRetry: test.currentRetry(), | ||
| err: errorJSON(test.err || {}) | ||
| err: cleanCycles(err) | ||
| }; | ||
| } |
There was a problem hiding this comment.
minor issue. We need an empty line here.
outsideris
approved these changes
Apr 8, 2018
Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
This was referenced Sep 22, 2018
Closed
Closed
This was referenced Oct 2, 2018
This was referenced Oct 25, 2018
This was referenced Nov 1, 2018
This was referenced Nov 19, 2018
This was referenced Dec 1, 2018
This was referenced Dec 8, 2018
This was referenced Dec 23, 2018
sgilroy
pushed a commit
to TwineHealth/mocha
that referenced
this pull request
Feb 27, 2019
) original work by @jeversmann; continuation of PR mochajs#2559 Signed-off-by: Christopher Hiller <boneskull@boneskull.com>
This was referenced Mar 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #2559.