-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs HTML fixes #3795
docs HTML fixes #3795
Conversation
@@ -1491,7 +1491,7 @@ A typical setup might look something like the following, where we call `mocha.se | |||
<head> | |||
<meta charset="utf-8" /> | |||
<title>Mocha Tests</title> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
<meta name="viewport" content="width=device-width, initial-scale=1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some reason, something that injects or formats the snippets, adds the useless end tags. Not a big deal, it's just it's useless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome to the prettier hate club...
<link rel="stylesheet" href="css/normalize.css"> | ||
<link rel="stylesheet" href="css/style.css"> | ||
<link rel="stylesheet" href="css/prism.css"> | ||
<link rel="shortcut icon" href="favicon.ico"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I didn't change this here since we don't have a clear list of supported browsers and this is needed for IE.
@@ -1598,7 +1598,7 @@ tests as shown below: | |||
<head> | |||
<meta charset="utf-8" /> | |||
<title>Mocha Tests</title> | |||
<meta name="viewport" content="width=device-width, initial-scale=1.0" /> | |||
<meta name="viewport" content="width=device-width, initial-scale=1" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
initial-scale
defines a ratio -- hence, the number written in "float/double" format.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...which is fine an integer in this case.
{% for i in (0..29) %}[![](https://opencollective.com/mochajs/backer/{{ i }}/avatar.jpg)](https://opencollective.com/mochajs/backer/{{ i }}/website){: target="_blank" rel="noopener"}{% endfor %} | ||
{: .image-list id="_backers" } | ||
|
||
{% for i in (0..29) %}[![](https://opencollective.com/mochajs/backer/{{ i }}/avatar.jpg)](https://opencollective.com/mochajs/backer/{{ i }}/website){: target="\_blank" rel="noopener"}{% endfor %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the purpose of the added backslash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this could be prettier choking on the template code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all 11ty template stuff needs wrapping in
<!-- prettier-ignore -->
stuff
<!-- prettier-ignore-end -->
* use a lowercase `doctype`; it works the same, but it compresses slightly better * remove useless end tags
Refs #3783
Closes #3784 by superseding it.