Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch unhandled promise rejections during tests #4032

Closed
wants to merge 1 commit into from

Commits on Sep 26, 2019

  1. Catch unhandled promise rejections during tests

    Listen to the unhandledRejection event when running tests, catching promises who
    got rejected without being cared for, and failing the test in which said
    promises were left unhandled.
    
    This is only part of handling unhandled rejections, some things not yet included
    are:
    
    - Handling unhandled rejections outside spec tests (e.g. testhooks)
    - Making it work in a browser
    - Amend error messages which reference unhandled rejections
    - Testing the new signature of the `Runner.prototype.uncaught` method
    
    If this commit looks nice enough, a future commit will amend these shortcomings.
    Zirak committed Sep 26, 2019
    Configuration menu
    Copy the full SHA
    06f89c2 View commit details
    Browse the repository at this point in the history