-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speed in -R json option (#4226) #4434
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Please update test/reporters.json.spec.js
to reflect this change. You would likely modify an existing assertion, e.g.,
expect(runner, 'to satisfy', {
testResults: {
failures: [
{
title: testTitle,
file: testFile,
speed: expect.it('to be greater than', 0),
err: {
message: error.message
}
}
]
}
});
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could add this in lib/reporters/json-stream.js
as well?
And it needs to change test/reporters/json-stream.spec.js
like boneskull said.
I have changed |
OK. I changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this. I have a few suggestions. If you don't apply them, I will do so after merge.
Co-authored-by: Christopher Hiller <boneskull@boneskull.com>
Co-authored-by: Christopher Hiller <boneskull@boneskull.com>
Co-authored-by: Christopher Hiller <boneskull@boneskull.com>
Requirements
Description of the Change
I modified the
-R json
option to show speed.Alternate Designs
N/A
Why should this be in core?
#4226
Benefits
You can see speed result in
json reporter
Possible Drawbacks
N/A
Applicable issues
Fixes #4226