-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
match supporter's properties with supporter.js #4569
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
added
the
area: website
involving mochajs.org, but not necessarily involving docs
label
Feb 7, 2021
juergba
approved these changes
Feb 7, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@outsideris thanks for this speedy fix!
Preview build was fine, but production build was failed on Netlify. I will check it. |
juergba
added
type: bug
a defect, confirmed by a maintainer
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
labels
Feb 7, 2021
This was referenced Mar 6, 2021
Closed
This was referenced Mar 8, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area: website
involving mochajs.org, but not necessarily involving docs
semver-patch
implementation requires increase of "patch" version number; "bug fixes"
type: bug
a defect, confirmed by a maintainer
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, mochajs.org doesn't show any sponsors or backers.
I'm not sure when this problem occurred.
This commit introduced
SPONSOR_TIER
andBACKER_TIER
constants and then this commit use these constants forsupporters
's child properties name.So, we used
supporters.sponsors
andsupporters.backers
previously but, now it changed tosupporters.sponsor
andsupporters.backer
. However we didn't changesupporters.md
.