-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort devDependencies alphabetically #4692
Conversation
Signed-off-by: Outsider <outsideris@gmail.com>
@outsideris These five devDependencies build a group:
I had to pin their versions in order to fix an
I don't understand this statement. package.json isn't updated with So if this contribution just sorts devDependencies without any deeper reason, then IMO it does more harm than anything else. |
I didn't know about #4643 . In macOs, $ git clone git@github.com:mochajs/mocha.git
$ cd mocha
$ npm i
added 2479 packages, and audited 2480 packages in 15s
24 vulnerabilities (4 low, 7 moderate, 13 high)
To address issues that do not require attention, run:
npm audit fix
To address all issues (including breaking changes), run:
npm audit fix --force
Run `npm audit` for details.
$ git diff package.json
diff --git a/package.json b/package.json
index a645d2ad..117caed4 100644
--- a/package.json
+++ b/package.json
@@ -81,11 +81,9 @@
"devDependencies": {
"@11ty/eleventy": "^0.11.0",
"@11ty/eleventy-plugin-inclusive-language": "^1.0.0",
- "@babel/preset-env": "7.12.17",
"@babel/plugin-transform-regenerator": "7.12.1",
- "regenerator-transform": "0.14.5",
+ "@babel/preset-env": "7.12.17",
"@babel/runtime": "7.12.5",
- "regenerator-runtime": "0.13.7",
"@mocha/docdash": "^3.0.1",
"@rollup/plugin-babel": "^5.1.0",
"@rollup/plugin-commonjs": "^14.0.0",
@@ -137,6 +135,8 @@
"nyc": "^15.1.0",
"pidtree": "^0.5.0",
"prettier": "^1.19.1",
+ "regenerator-runtime": "0.13.7",
+ "regenerator-transform": "0.14.5",
"remark": "^12.0.1",
"remark-github": "^9.0.1",
"remark-inline-links": "^4.0.0" I didn't know I will check it why it happened. |
And |
I don't know. Btw I'm using npm v6.14.13. |
@outsideris a new version v0.13.9 of regenerator-runtime has been published a few days ago. This could solve our I'm going to test ... |
@juergba Good news. I'm adding tests to prevent |
In devDependencies, some modules isn't sorted alphabetically.
So, package.json will be updated whenever running
npm install
. It can make conflicts with others.