Add test to prevent ReDoS for clean() #4917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Outsider <outsideris@gmail.com>
outsideris
force-pushed
the
clean-redos-test
branch
from
8a37975
to
7dc6da7
Compare
|
I will merge this in a few days. |
|
@outsideris Imo this test has no benefit. |
|
I think this test prevent regression ReDoS because when we fix the RegExp, it is hard to ReDoS vulnerability. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
In #4770 , ReDoS vulnerabilities of the regex fixed. So, this test to prevent regression ReDoS.