fix: use original Error object for uncaught errors when provided in browser #5080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case of uncaught errors, mocha would print the error message, which is essentially the first line of the stack trace. The actual stack trace was unused.
|
|
3 tasks
JoshuaKGoldberg
requested changes
Mar 4, 2024
| if (!error) { | ||
| error = new Error(err + ' (' + url + ':' + line + ')'); | ||
| } | ||
| fn(error); |
There was a problem hiding this comment.
Aha! I'd filed #5106 before seeing this PR. Great. I'll close that one since this once came first.
[Feature] What do you think about including ':' + col too, per https://github.com/mochajs/mocha/pull/5107/files#diff-c282db01f80ee266af40ae81278d9d99177c763ae242fdeb38ee33c603598a2fR75 ?
Request adding it in as a new nicety, unless you know of a reason not to.
There was a problem hiding this comment.
[Testing] Could you add a unit test too, please?
#5107 has a reference if that's helpful.
JoshuaKGoldberg
added
status: waiting for author
JoshuaKGoldberg
changed the title
|
I appreciate your concern, but it would probably much simpler if you just merged your PR. Just close mine, no worries :)
…On March 4, 2024 7:38:49 PM GMT+01:00, "Josh Goldberg ✨" ***@***.***> wrote:
@JoshuaKGoldberg requested changes on this pull request.
Lovely! 🙌
Requesting changes on the unit test & including column.
> @@ -71,8 +71,11 @@ process.listenerCount = function (name) {
process.on = function (e, fn) {
if (e === 'uncaughtException') {
- global.onerror = function (err, url, line) {
- fn(new Error(err + ' (' + url + ':' + line + ')'));
+ global.onerror = function (err, url, line, colno, error) {
+ if (!error) {
+ error = new Error(err + ' (' + url + ':' + line + ')');
+ }
+ fn(error);
Aha! I'd filed #5106 before seeing this PR. Great. I'll close that one since this once came first.
[Feature] What do you think about including `':' + col` too, per https://github.com/mochajs/mocha/pull/5107/files#diff-c282db01f80ee266af40ae81278d9d99177c763ae242fdeb38ee33c603598a2fR75 ?
Request adding it in as a new nicety, unless you know of a reason not to.
On browser-entry.js:
[Testing] Could you add a unit test too, please?
#5107 has a reference if that's helpful.
--
Reply to this email directly or view it on GitHub:
#5080 (review)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
958 (which is closed but not really fixed)🐛 Bug: Browser doesn't include call stack for global uncaught errors #5106status: accepting prsOverview
In case of uncaught errors, mocha would print only the error message, which is essentially the first line of the stack trace. The actual stack trace was unused. This is essentially #2403 which was closed for inactivity.
Here's a fiddle demonstrating the problem: https://jsfiddle.net/Lru1q4n6/ (updated from the PR above). Unfortunately, I don't know how to demonstrate the fix there. Of course it does work locally, I used this fix to debug our tests.
Co-authored-by: @mgiuffrida