Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow using any 3.x chokidar dependencies #5143

Merged
merged 1 commit into from
May 24, 2024

Conversation

simhnna
Copy link
Contributor

@simhnna simhnna commented May 16, 2024

PR Checklist

Overview

Compatibility with newer @types/node releases for typescript users

Copy link

linux-foundation-easycla bot commented May 16, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: simhnna / name: Simon Hanna (03934ab)

package.json Outdated Show resolved Hide resolved
package-lock.json Show resolved Hide resolved
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Up for switching to ^ and having this target the chokidar part of #5114?

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author waiting on response from OP - more information needed label May 24, 2024
@simhnna simhnna changed the title chore: bump chokidar to ^3.6.0 chore: allow using any 3.x chokidar dependencies May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg changed the title chore: allow using any 3.x chokidar dependencies feat: allow using any 3.x chokidar dependencies May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author waiting on response from OP - more information needed label May 24, 2024
@JoshuaKGoldberg JoshuaKGoldberg self-requested a review May 24, 2024 12:56
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thanks!

@JoshuaKGoldberg
Copy link
Member

I also tried an npm upgrade chokidar locally and re-running tests and such. They all worked. ✔️

@JoshuaKGoldberg JoshuaKGoldberg merged commit 472a8be into mochajs:master May 24, 2024
26 of 27 checks passed
@coveralls
Copy link

Coverage Status

coverage: 94.358%. remained the same
when pulling 03934ab on simhnna:bump-chokidar
into 99601da on mochajs:master.

@JoshuaKGoldberg
Copy link
Member

This was released in mocha@10.5.0. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants