Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add file field for exports interface #5147

Closed
wants to merge 1 commit into from
Closed

fix: add file field for exports interface #5147

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/interfaces/exports.js
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Testing] The change looks good to me, but it'd be good to have test coverage. Could you please add one to exports.spec.js?

Even just a straightforward expect(this.test.file, 'to match', ...) would be fine enough IMO.

Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ module.exports = function (suite) {
}
} else {
suite = Suite.create(suites[0], key);
suite.file = file;
suites.unshift(suite);
visit(obj[key], file);
suites.shift();
Expand Down
Loading