Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow ^ versions for character encoding packages #5150

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented May 30, 2024

PR Checklist

Overview

Adds a ^ range to the following packages related to character encoding in logs:

  • ansi-colors: new minor versions available, up to 4.1.3 - which it's upgraded to now
  • browser-stdout: latest version; hasn't been updated in 6 years
  • escape-string-regexp: no new minor versions available - just a new major
  • he: latest version; hasn't been updated in 6 years
  • log-symbols: no new minor versions available - just new majors
  • supports-color: no new minor versions available - just a new major

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 8d8af57 to 352b483 Compare May 30, 2024 21:02
@coveralls
Copy link

coveralls commented May 30, 2024

Coverage Status

coverage: 94.359% (+0.001%) from 94.358%
when pulling 5d9818f on JoshuaKGoldberg:minor-versions-character-encoding-packages
into 472a8be on mochajs:master.

@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 352b483 to 993c3a6 Compare May 30, 2024 21:06
@JoshuaKGoldberg JoshuaKGoldberg force-pushed the minor-versions-character-encoding-packages branch from 993c3a6 to 00a7f9f Compare May 30, 2024 21:09
@JoshuaKGoldberg JoshuaKGoldberg added the semver-minor implementation requires increase of "minor" version number; "features" label May 30, 2024
@JoshuaKGoldberg JoshuaKGoldberg requested a review from a team May 30, 2024 21:13
Copy link
Member

@voxpelli voxpelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one change looks indeed harmless: doowb/ansi-colors@4.1.1...4.1.3

But can you do a new npm install ansi-colors@^4.1.3 to ensure that our lockfile actually also references it?

package.json Outdated Show resolved Hide resolved
@JoshuaKGoldberg JoshuaKGoldberg requested a review from voxpelli June 22, 2024 23:11
@JoshuaKGoldberg JoshuaKGoldberg merged commit 38695da into mochajs:main Jul 2, 2024
25 checks passed
@JoshuaKGoldberg JoshuaKGoldberg deleted the minor-versions-character-encoding-packages branch July 2, 2024 15:46
@JoshuaKGoldberg
Copy link
Member Author

Released in mocha@v10.6.0. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor implementation requires increase of "minor" version number; "features"
Projects
None yet
Development

Successfully merging this pull request may close these issues.

📦 Package: Switch dependency versions to ^ ranges
3 participants