Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in millisecond-to-string logic #948

Closed
wants to merge 1 commit into from

Conversation

jugglinmike
Copy link
Contributor

Since I needed to create a new test file for the ms module, I rounded it off by testing the entire module. I can imagine that these tests might be too low-level, so if you'd prefer, I can try writing integration-style tests instead.

Commit message:

When generating a string representation of a millisecond duration, use
the rounded value to determine if the unit should be pluralized.

This commit also introduces unit tests for previously-untested string
parsing logic belonging to the same module.

When generating a string representation of a millisecond duration, use
the rounded value to determine if the unit should be pluralized.

This commit also introduces unit tests for previously-untested string
parsing logic belonging to the same module.
@tj
Copy link
Contributor

tj commented Aug 12, 2013

i think this was fixed in https://github.com/guille/ms.js, we could copy/paste that over

@jugglinmike
Copy link
Contributor Author

It looks like it was. Is there any reason not to include it as a module?

@jugglinmike
Copy link
Contributor Author

I see why now: mocha's build process isn't currently set up to package NPM modules for the browser. I've opened a new pull request to address the underlying bug: #957

@tj
Copy link
Contributor

tj commented Aug 21, 2013

yeah it's a bit hacky right now haha, pre-{browserify,component} era

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants